Skip to content

fix: MessageConverterImpl 누락된 List/Record 필드 NullPointerException 방지 #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
z3rotig4r wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: MessageConverterImpl 누락된 List/Record 필드 NullPointerException 방지 #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...ice/src/main/java/org/egovframe/rte/itl/webservice/service/impl/MessageConverterImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ public Object convertToValueObject(Object source, Type type) throws ClassNotFoun
return source;
} else if (type instanceof ListType) {
LOGGER.debug("### MessageConverterImpl convertToValueObject() : Type is a List Type");
// 메시지 body에서 List 필드가 생략되면 source가 null로 전달된다.
// 타입 체계가 null을 유효 값으로 허용하므로, 역참조 전에 null을 그대로 반환한다.
if (source == null) {
return null;
}
ListType listType = (ListType) type;
Object[] components = ((Collection<?>) source).toArray();
Class<?> arrayClass = classLoader.loadClass(listType);
Expand All @@ -85,6 +90,11 @@ public Object convertToValueObject(Object source, Type type) throws ClassNotFoun
return array;
} else if (type instanceof RecordType) {
LOGGER.debug("### MessageConverterImpl convertToValueObject() : Type is a Record(Map) Type");
// 메시지 body에서 Record 필드가 생략되면 source가 null로 전달된다.
// 타입 체계가 null을 유효 값으로 허용하므로, 역참조 전에 null을 그대로 반환한다.
if (source == null) {
return null;
}
RecordType recordType = (RecordType) type;
Map<String, Object> map = (Map<String, Object>) source;
Class<?> recordClass = classLoader.loadClass(recordType);
Expand Down
14 changes: 14 additions & 0 deletions ...src/test/java/org/egovframe/rte/itl/webservice/service/impl/MessageConverterImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,20 @@ public void testConvertToTypedObject() throws Exception {
assertEquals(person.name, personMap.get("name"));
}
}

@Test
public void testConvertToValueObjectWithNullListSource() throws Exception {
// 메시지 body에서 List 필드가 생략되면 source가 null로 전달된다.
// null 역참조(NPE) 없이 null을 반환해야 한다.
assertNull(messageConverter.convertToValueObject(null, personListType));
}

@Test
public void testConvertToValueObjectWithNullRecordSource() throws Exception {
// 메시지 body에서 Record 필드가 생략되면 source가 null로 전달된다.
// null 역참조(NPE) 없이 null을 반환해야 한다.
assertNull(messageConverter.convertToValueObject(null, recordType));
}
}

class ValueObject {
Expand Down