chore: Batch 모듈의 System.out.println을 SLF4J LOGGER로 대체#272
Open
EricSeokgon wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
수정 사유
Batch 모듈 3개 클래스가 셸 실행 출력과 배치 설정 정보를
System.out.println으로 콘솔에 직접 출력하고 있습니다. 표준 출력 직접 사용은 로그 레벨·포맷·출력 대상 제어가 불가능하고 운영 환경 로그 수집에서 누락되며, 정적분석 도구가 지적하는 항목입니다(PMDSystemPrintln, SonarQubejava:S106). 저장소의 다른 코드와 동일하게 SLF4J LOGGER를 사용하도록 정리했습니다. egovframe-common-components의 동일 계열 PR(eGovFramework/egovframe-common-components#1097, #1118)의 실행환경 버전입니다.수정 내용
bat/core/step/ShellScriptSupport.javaLOGGER.info("{}", line)으로 대체. SLF4J Logger 필드·import 추가bat/item/DefaultItemReader.javaLOGGER.info로 대체 (기존 LOGGER 필드 재사용)bat/item/DefaultItemWriter.javaLOGGER.info로 대체 (기존 LOGGER 필드 재사용)테스트 여부
mvn compile통과 (JDK 17)