Skip to content

Check data is taken in RpcBridge::transmit_#142

Merged
juanlofer-eprosima merged 1 commit into
eProsima:mainfrom
fujitatomoya:check-if-reader-taken-data
Mar 28, 2025
Merged

Check data is taken in RpcBridge::transmit_#142
juanlofer-eprosima merged 1 commit into
eProsima:mainfrom
fujitatomoya:check-if-reader-taken-data

Conversation

@fujitatomoya
Copy link
Copy Markdown
Contributor

found this bug during #141.

Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
@fujitatomoya
Copy link
Copy Markdown
Contributor Author

CC: @MiguelCompany @Barry-Xu-2018

Copy link
Copy Markdown
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! Would you mind if I change the name of the PR?

@fujitatomoya
Copy link
Copy Markdown
Contributor Author

please go ahead to do that, i do not mind it at all 👍

@juanlofer-eprosima juanlofer-eprosima changed the title should check the return code before accessing the taken data. Check data is taken in RpcBridge::transmit_ Mar 28, 2025
@juanlofer-eprosima juanlofer-eprosima merged commit 4e76d67 into eProsima:main Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants