[#24574] Fix macOS build issues in YAML parsing and CLI arguments

[Danipiza]

Description

This PR fixes two macOS compilation issues in DDS-Record-Replay.

Changes

1. Make std::string extraction explicit in ddsrecorder_yaml by using get_reference() instead of relying on implicit conversion from utils::Fuzzy<std::string>.
2. Rename the CLI option enum entry DOMAIN to DOMAIN_ID in ddsrecord_tool and ddsreplay_tool to avoid colliding with the DOMAIN macro defined by macOS system headers.

Errors

1.

--- stderr: fastddsspy_yaml                             
/Users/macmini/workspace_dev_utils/src/Fast-DDS-Spy/fastddsspy_yaml/src/cpp/YamlReaderConfiguration.cpp:189:31: error: call to constructor of 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char>>') is ambiguous
  189 |             const std::string key(topic.first->topic_name);
      |                               ^   ~~~~~~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string:822:5: note: candidate constructor
  822 |     basic_string(const basic_string& __str);
      |     ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string:827:5: note: candidate constructor
  827 |     basic_string(basic_string&& __str)
      |     ^
/Users/macmini/workspace_dev_utils/src/Fast-DDS-Spy/fastddsspy_yaml/src/cpp/YamlReaderConfiguration.cpp:193:21: error: ambiguous conversion for static_cast from 'utils::Fuzzy<std::string>' (aka 'Fuzzy<basic_string<char, char_traits<char>, allocator<char>>>') to 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char>>')
  193 |                     static_cast<std::string>(topic.first->content_topic_filter);
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string:822:5: note: candidate constructor
  822 |     basic_string(const basic_string& __str);
      |     ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string:827:5: note: candidate constructor
  827 |     basic_string(basic_string&& __str)

2.

In file included from /Users/macmini/workspace_dev_utils/src/Fast-DDS-Spy/fastddsspy_tool/src/cpp/user_interface/arguments_configuration.cpp:30:
/Users/macmini/workspace_dev_utils/src/Fast-DDS-Spy/fastddsspy_tool/src/cpp/user_interface/arguments_configuration.hpp:102:5: error: expected identifier
  102 |     DOMAIN,
      |     ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/math.h:781:17: note: expanded from macro 'DOMAIN'
  781 | #define DOMAIN          1
      |                         ^
/Users/macmini/workspace_dev_utils/src/Fast-DDS-Spy/fastddsspy_tool/src/cpp/user_interface/arguments_configuration.cpp:105:22: error: expected unqualified-id
  105 |         optionIndex::DOMAIN,

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.46%. Comparing base (10331f3) to head (f1affd7).

Files with missing lines	Patch %	Lines
..._yaml/src/cpp/recorder/YamlReaderConfiguration.cpp	0.00%	2 Missing ⚠️
...src/cpp/user_interface/arguments_configuration.cpp	0.00%	1 Missing ⚠️
...src/cpp/user_interface/arguments_configuration.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   28.49%   28.46%   -0.04%     
==========================================
  Files          77       77              
  Lines        5186     5186              
  Branches     2720     2720              
==========================================
- Hits         1478     1476       -2     
- Misses       2500     2501       +1     
- Partials     1208     1209       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ZakariaTalbi]

LGTM with green CI