Skip to content

Use different Vulcanexus images for each Fast DDS version #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanlofer-eprosima merged 2 commits into from
Jun 20, 2025
Merged

Use different Vulcanexus images for each Fast DDS version #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab2b47
Use humble with 2.x
cferreiragonz Jun 13, 2025
5ad4819
Remove temp workaroud for ROS 2 apt keys
cferreiragonz Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/docker/vulcanexus/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,6 @@ SHELL ["/bin/bash", "-c"]
ARG docker_image_base
RUN echo "Docker Base image used: ${docker_image_base}"

# TODO: Remove once external issue is solved
# Update ROS 2 keys (not updated in the base image as of June 2025)
RUN rm /etc/apt/sources.list.d/ros2-latest.list && \
curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /usr/share/keyrings/ros-archive-keyring.gpg && \
echo "deb [signed-by=/usr/share/keyrings/ros-archive-keyring.gpg] http://packages.ros.org/ros2/ubuntu $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/ros2.list > /dev/null

# Install message interface and demo nodes required packages
RUN source "/opt/vulcanexus/$VULCANEXUS_DISTRO/setup.bash" && \
apt-get update && \
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/docker-reusable-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ jobs:
env:
DDSROUTER_COMPOSE_TEST_DOCKER_IMAGE: "ddsrouter:ci"
DDSROUTER_COMPOSE_TEST_ROS2_DOCKER_IMAGE: "vulcanexus:ci"
VULCANEXUS_IMAGE: ${{ startsWith(inputs.fastdds_branch, '2.') && 'eprosima/vulcanexus:humble-core' || 'eprosima/vulcanexus:jazzy-core' }}

steps:

Expand All @@ -80,7 +81,7 @@ jobs:
cd ./src/.github/docker/vulcanexus
docker build \
--no-cache \
--build-arg docker_image_base=eprosima/vulcanexus:jazzy-core \
--build-arg docker_image_base=${{ env.VULCANEXUS_IMAGE }} \
-t ${{ env.DDSROUTER_COMPOSE_TEST_ROS2_DOCKER_IMAGE }} \
-f Dockerfile .

Expand Down
Loading