Skip to content

Extend noinline to gcc >= 12 to fix -Werror=maybe-uninitialized false positives in gcc 15#311

Merged
MiguelCompany merged 1 commit into
eProsima:masterfrom
christophebedard:christophebedard/extend-noinline-to-newer-gcc-versions
May 11, 2026
Merged

Extend noinline to gcc >= 12 to fix -Werror=maybe-uninitialized false positives in gcc 15#311
MiguelCompany merged 1 commit into
eProsima:masterfrom
christophebedard:christophebedard/extend-noinline-to-newer-gcc-versions

Conversation

@christophebedard
Copy link
Copy Markdown
Contributor

@christophebedard christophebedard commented May 9, 2026

Description

A build failure can be reproduced with colcon's --mixin coverage-gcc (or -DCMAKE_C_FLAGS='--coverage' -DCMAKE_CXX_FLAGS='--coverage') on Ubuntu 26.04, which has gcc 15.2.0 by default.

Relates to eProsima/Fast-DDS#5277. It seems like this false positive issue keeps popping up in more recent versions of gcc, since (I believe) that issue/bug report is newer than gcc 12. It definitely fixes my issue reported at eProsima/Fast-DDS#5277 (comment).

@Mergifyio backport 2.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

… positives in gcc 15

A build failure can be reproduced with colcon's `--mixin coverage-gcc`
(or `-DCMAKE_C_FLAGS='--coverage' -DCMAKE_CXX_FLAGS='--coverage'`) on
Ubuntu 26.04, which has gcc 15.2.0 by default.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima May 9, 2026 20:14
@MiguelCompany MiguelCompany added this to the v2.3.6 milestone May 11, 2026
@MiguelCompany MiguelCompany merged commit 00e324d into eProsima:master May 11, 2026
12 checks passed
@MiguelCompany
Copy link
Copy Markdown
Member

@Mergifyio backport 2.2.x

@mergify
Copy link
Copy Markdown

mergify Bot commented May 11, 2026

backport 2.2.x

✅ Backports have been created

Details

@christophebedard christophebedard deleted the christophebedard/extend-noinline-to-newer-gcc-versions branch May 11, 2026 20:22
MiguelCompany pushed a commit that referenced this pull request May 12, 2026
… positives in gcc 15 (#311) (#312)

A build failure can be reproduced with colcon's `--mixin coverage-gcc`
(or `-DCMAKE_C_FLAGS='--coverage' -DCMAKE_CXX_FLAGS='--coverage'`) on
Ubuntu 26.04, which has gcc 15.2.0 by default.


(cherry picked from commit 00e324d)

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants