improve build scripts by Naruto · Pull Request #8 · eXperiencePoints/XPCoin

Naruto · 2017-12-19T13:15:55Z

Purposes

fix XP-Qt and XPd build options and scripts for current version macOS, Linux and Windows(MSVC).
~~make sense build document.~~ dropped
~~Build scripts can running on Cloud CI Service.~~ dropped
~~change default db library from bdb to leveldb.~~ using bdb

Status

macOS
- XPd
- XP-Qt
- release build
Windows
- XPd
- XP-Qt
- release build
Linux
- XPd
- XP-Qt
- ~~release build~~ dropped this PR. next action is create deb package #35

Changes

Fixed build error when boost v1.66 over was used.( Fixed build error when boost v1.66 over was used. #17 )
Fixed build error when adding -std=gnuc++11 or -std=c++11 to build options. ( 92b9bb5 )
Upgraded Qt major version from 4 to 5.

Himan2001 · 2017-12-20T12:37:39Z

For Windows improvement please modify the scripts for building ALL static, so no more external libs needed.
This is often a problem on different Windows-Version with the .dll files.

mauriciosl · 2017-12-20T14:05:40Z

+
+isEmpty(QRENCODE_INCLUDE_PATH) {
+    macx:QRENCODE_INCLUDE_PATH=/usr/local/opt/qrencode/include
+    widnwos:QRENCODE_INCLUDE_PATH=C:/deps/qrencode-3.4.4


typo:

widnwos:QRENCODE_INCLUDE_PATH=C:/deps/qrencode-3.4.4
means windows - not widnwos :)

Don't worry. I will fix typo when will support windows build

Naruto · 2017-12-20T16:15:40Z

@Himan2001
I will use same library type as other cryptocurrency implementation.
Other cryptocurrency such as bitcoin or litecoin use static library?

Himan2001 · 2017-12-20T21:06:35Z

Syncing leveldb for linux AND windows is a nice move, but the .dll shared problems needs still to be fixed.
I have with this fork exactly the same issues as with CharlieChaplinCoin. The build scripts needs
more revised to build ENTIRE static for the windows version. By using mxe as cross tool, this is usualy
no problem - but for that a "configure" with an "--prefix=" option is missing for the regulary makefiles.

There are to many native default linux-libs still in use. Only the paths for boost, qt, libdb and qt are coverd by the makefiles. When cross compiling for windows this is an importent factor to not mix the linux-libs/headers with the versions that the cross-tool (can) use. One of this quick fixes is, to put all needed libs and headers in other directorys and modify the PATH enviroment to no longer uses /usr/lib and /usr/include, but this has to many side effects.

My advice is, to use the "depends" subdir, that actual BTG, MONA, LTC, etc. have. This makes sure, that you can build with specific versions of all libs for any platform and cross compiling is very well working ;-)

One more aspect is the combination of: USE_ASM and USE_SSE2 - this is not always clear. Later Forks don´t have this options any longer - so my hint is: just remove this option and use the fast version for actual hardware. Last but not least: Remove the scrypt-code, that is no longer needed.

And my last point is a hint of switching to qt5.x - compared with PowerCoin, where qt4 was originaly used, i build with success a 1:1 qt5 version. On XP-fork just a few lines for qt calls need adopted, and qt4 can be retired ;-)

Himan2001 · 2017-12-20T21:18:58Z

@Naruto: yes, it does. Only 3-4 year old forks has this windows .dll stuff. In the last 2 years i saw no longer windows binarys with more then one .exe file ;-)

As i stated above, switching to configure and use "depends" dir solve all this problems, because the mxe-tool build ALL needed libs dynamic and static for any platform. By using mxe and the existing versions you have the darwin support included by the way. And of course: 32 and 64 bit destination code for windows are much more easy buildable.

I noted, when i use generally under linux the "depends"-Version for Doge, BTG and MONA, the entire things can be static - including x11 and qt5 libs. so the maximum that is needed are only 4 system-libs
from the glibc6 itself. You have maximum compatibility for many linuxes then.

I see in older fork-code mostly dynamic code for libboost and qtX - reason is, that on ubuntu the static (.a)libs are not part of the distribution, so the linker cannot build this parts static inside the final file.
The problem on libboost is, that nearly every linux uses a different version. Main problems are, that libs not found for many end-users later. (boost 1.58 on ubuntu 16, newer on 17.x, and mxe uses 1.60+, etc...)

Before you now hardcode specific versions for every hardware... better switch to "depends-system" and
get rid of all this issues at once. ;-)

This reverts commit f7cda35.

fix boost download option to redirectable

fix batchfile

[WIP] support MSVC

Naruto · 2018-03-07T13:13:45Z

@mauriciosl
@Himan2001
support windows. please review.

SOELexicon · 2018-03-08T23:39:20Z

+call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat" x86
+cd %BASEDIR%
+nmake distclean
+C:\Qt\5.10.1\msvc2015\bin\qmake.exe -spec win32-msvc || exit /b 1


this line had to be changed for my build for some reason it installed at 5.10.1 inside a subfolder
C:\Qt\Qt5.10.1\5.10.1\msvc2015\bin\windeployqt --release output\XP-Qt\XP-Qt.exe || exit /b 1

SOELexicon · 2018-03-08T23:39:24Z

+rmdir /S/Q output\XP-Qt
+mkdir output\XP-Qt
+copy release\XP-Qt.exe output\XP-Qt
+C:\Qt\5.10.1\msvc2015\bin\windeployqt --release output\XP-Qt\XP-Qt.exe || exit /b 1


this line had to be changed for my build for some reason it installed at 5.10.1 inside a subfolder
C:\Qt\Qt5.10.1\5.10.1\msvc2015\bin\windeployqt --release output\XP-Qt\XP-Qt.exe || exit /b 1
Compiled perfect after that

SOELexicon

after making a few changes to one of the .bats due to my qt path being different it compiled perfect.

Naruto · 2018-03-08T23:56:28Z

@SOELexicon
Would you have idea that avoids Qt path problem?
If you don't have it, you should consider solution at next phase.
Currently, I don't have time for resolving this problem.

mauriciosl reviewed Dec 20, 2017

View reviewed changes

Naruto force-pushed the feature/add_appveyor_script branch 3 times, most recently from 8fec978 to 0637d98 Compare December 28, 2017 07:45

Naruto force-pushed the feature/add_appveyor_script branch from 0637d98 to 01abbc8 Compare January 28, 2018 08:56

Naruto force-pushed the feature/add_appveyor_script branch from 01abbc8 to f15d7fe Compare February 22, 2018 13:03

Naruto changed the base branch from master to develop February 22, 2018 13:12

Naruto force-pushed the feature/add_appveyor_script branch 2 times, most recently from ddc7cc9 to d4ebeb7 Compare February 22, 2018 13:28

Naruto force-pushed the feature/add_appveyor_script branch from 0204fe9 to e251db0 Compare March 3, 2018 05:55

Naruto added 16 commits March 4, 2018 12:05

update makefile.osx

4a35ea8

fix build error on C++11

50d950c

update .gitignore

b434d12

update xp.pro

559c875

change llvm-g++ to clang++

20ef642

fix .gitignore

723897b

update build-osx.txt

1d7d552

update .gitignore for linux

2a2a239

change default db library to leveldb on macos

30a2262

add readme-qt5.rst

629029d

remove xcode-beta path of release build

cddfa03

fix build error of boost since v1.66

e40c682

Revert "change default db library to leveldb on macos"

e7b1c6c

This reverts commit f7cda35.

update Qt5 docs

48bb9bf

update doc/build-osx.txt

2c746da

remove static link flag at linux release build

92da834

Naruto and others added 22 commits March 4, 2018 12:06

deveploy lib and include to lib/openssl

a963b03

update bat files

8cefd1b

support msvc debug build

0230947

avoid windows builderror by adhoc

0e79179

download openssl precompile binary

a3f5040

fix 7zip package name

bb460d0

fix boost download option to redirectable

update CMakeLists.txt

13a6e6f

forgot commit

8ca676a

Merge pull request #4 from chocoa/feature/support_windows

fd2ca96

fix batchfile

fix release build on Windows

e3e8a9a

use cmake -E echo

cec9ec4

add MSVC/.gitignore

cbf4f94

update qrencode.bat

f914c69

fix

ecce4e1

add XPd.bat

360de5b

udpate .gitiignore

7212639

update berkeleydb.bat

c962211

add jom

c7e8370

update xp.pro

f0701a1

add XP-Qt.bat

ff12638

update .gitignore

51afa21

Merge pull request #3 from Naruto/feature/support_windows

6527cba

[WIP] support MSVC

Naruto changed the title ~~[WIP] improve build scripts~~ improve build scripts Mar 8, 2018

update and fix bat files.

8ecdba9

SOELexicon reviewed Mar 8, 2018

View reviewed changes

SOELexicon approved these changes Mar 8, 2018

View reviewed changes

8kpx merged commit bd20604 into eXperiencePoints:develop Mar 9, 2018

Uh oh!

Conversation

Naruto commented Dec 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purposes

Status

Changes

Uh oh!

Himan2001 commented Dec 20, 2017

Uh oh!

mauriciosl Dec 20, 2017

Choose a reason for hiding this comment

Uh oh!

Naruto Dec 20, 2017

Choose a reason for hiding this comment

Uh oh!

Himan2001 Dec 20, 2017

Choose a reason for hiding this comment

Uh oh!

Naruto Dec 21, 2017

Choose a reason for hiding this comment

Uh oh!

Naruto commented Dec 20, 2017

Uh oh!

Himan2001 commented Dec 20, 2017

Uh oh!

Himan2001 commented Dec 20, 2017

Uh oh!

Naruto commented Mar 7, 2018

Uh oh!

SOELexicon Mar 8, 2018

Choose a reason for hiding this comment

Uh oh!

SOELexicon Mar 8, 2018

Choose a reason for hiding this comment

Uh oh!

SOELexicon left a comment

Choose a reason for hiding this comment

Uh oh!

Naruto commented Mar 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Naruto commented Dec 19, 2017 •

edited

Loading