Repository navigation
Fix frontend build: pin @vitejs/plugin-react to ^5.2.0 - #40
Merged
Merged
Conversation
plugin-react@6 requires vite@^8, and vite@8 requires Node 22 — the CI runner is on Node 20. Downgrade to plugin-react@5, which supports vite@5/6/7 on Node 20. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
React 19's useRef<T | null>(null) returns RefObject<T | null>, not RefObject<T> — the ResultsPanel/PlotAndControls prop types need to match. Only the two prop-type annotations changed; the useRef and consumers are already null-safe. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vitejs/plugin-react@^6.1.1, which requiresvite@^8.vite@8needs Node 22, but CI is on Node 20 and the package pinsvite@^7.3.0— sonpm installfailed with ERESOLVE, breaking the Smoke tests build.^5.2.0(supports vite 5/6/7 on Node 20). No other changes.Test plan
cd frontend && npm install && npm run build🤖 Generated with Claude Code