Open
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6828523 |
- Add Dockerfile for production environment with PHP 8.2, Nginx, and Supervisor - Add Dockerfile.dev for development environment with Node.js and Redis support - Add docker-compose.yml with services for app, database, Redis, and phpMyAdmin - Add comprehensive DOCKER.md documentation with setup instructions - Add docker-setup.sh script for easy environment setup - Add .dockerignore to optimize build context
- Add dev-start.sh script with database wait logic and process management - Add custom.ini for PHP configuration without duplicate extensions - Add nginx.conf for web server configuration - Add supervisord configurations for production and development - Add mysql init.sql for database initialization - Implement robust startup script with cleanup and verification
- Add server configuration with host 0.0.0.0 for external access - Configure HMR (Hot Module Replacement) for localhost - Set explicit port 5173 for consistent development experience - Enable proper asset serving in containerized environment
- Update .gitignore to exclude Docker-related temporary files - Update package-lock.json with latest dependency resolutions - Ensure consistent development environment setup
- Add phpMyAdmin service management to docker-setup.sh script - Add support for multiple environment commands (dev, dev-full, prod, phpmyadmin) - Update DOCKER.md documentation with phpMyAdmin instructions - Add convenient commands for starting development environment with database management - Improve script usability with help command and better parameter handling Usage examples: - ./docker-setup.sh dev-full # Start dev environment with phpMyAdmin - ./docker-setup.sh phpmyadmin # Start only phpMyAdmin - docker compose up -d dev phpmyadmin # Alternative command
4e768c8 to
6828523
Compare
earhackerdem
added a commit
that referenced
this pull request
Oct 12, 2025
…king This commit fixes all blocking issues found in PR #38 that would prevent the Docker configuration from functioning correctly. ## Critical Fixes ### 1. Dockerfile (Production) - Lines 19-20, 59 **Problem**: Missing Redis PHP extension and incorrect PHP config path - Add Redis PHP extension installation via PECL - Fix PHP config path from `docker/php.ini` to `docker/php/custom.ini` **Impact**: Resolves "Class Redis not found" error in production ### 2. docker-setup.sh - Line 64 **Problem**: References non-existent `docker.env` file - Change from `cp docker.env .env` to `cp .env.example .env` **Impact**: Setup script now works out of the box ### 3. docker.env - NEW FILE **Problem**: File was in .gitignore but never committed - Create docker.env with Docker-optimized environment variables - Configure for MariaDB (host=db) and Redis (host=redis) - Include all necessary Laravel configuration **Impact**: Users have a working Docker environment template ### 4. DOCKER.md - Lines 31-33, 42-43 **Problem**: Inconsistent database credentials documentation - Update password from `cronosmatic123` to `cronosmatic_password` - Update database name from `cronosmatic_store` to `cronosmatic` **Impact**: Documentation matches actual docker-compose.yml config ## Verification All fixes have been tested and verified: ✅ Development Dockerfile builds successfully ✅ Production Dockerfile builds successfully ✅ Redis extension installed and loaded in both images ✅ PHP config file copied correctly in both images ✅ docker-compose.yml validates without errors ✅ MariaDB and Redis services start and pass health checks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐋 Configuración Completa de Docker para Desarrollo y Producción
📋 Resumen
Este PR implementa una configuración completa de Docker para el proyecto CronosMaticStore, proporcionando entornos de desarrollo y producción completamente funcionales con todas las dependencias necesarias.
🎯 Características Implementadas
✅ Entornos Docker
✅ Problemas Resueltos
🚀 Nuevas Funcionalidades
Script de Setup Mejorado
Comandos Docker Directos
📦 Archivos Añadidos/Modificados
Nuevos Archivos:
Dockerfile- Configuración de producciónDockerfile.dev- Configuración de desarrollodocker-compose.yml- Orquestación de serviciosdocker-setup.sh- Script de configuración automáticaDOCKER.md- Documentación completa.dockerignore- Optimización de contexto de builddocker/- Directorio de configuracionesdev-start.sh- Script de inicio robustophp/custom.ini- Configuración PHP optimizadanginx.conf- Configuración Nginxsupervisord.conf- Configuración Supervisormysql/init.sql- Inicialización de DBArchivos Modificados:
vite.config.ts- Configuración para Docker.gitignore- Exclusiones Dockerpackage-lock.json- Dependencias actualizadas🌐 URLs de Acceso
cronosmatic/cronosmatic_passwordcronosmatic/cronosmatic_password🔧 Configuración Técnica
Desarrollo:
Producción:
Base de Datos:
🛡️ Mejoras de Robustez
📚 Documentación
🧪 Testing
🎉 Beneficios
./docker-setup.sh dev-full🔄 Próximos Pasos
Una vez mergeado este PR:
./docker-setup.sh dev-fullpara desarrollo./docker-setup.sh prod