feat: add edge-based fish detection to green channel - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances sonar video preprocessing with edge-based fish detection in the green channel, providing a triple-channel visualization for improved fish identification.
Changes
Core Improvements
API Improvements
PreprocessingResultdataclass for type safety and claritypreprocess_frame()matching CLI defaultsNew CLI Parameters
Both
preprocess_sonar_video.pyandstabilize_and_preprocess_sonar_video.pynow support:--edge-canny-low: Lower threshold for Canny edge detection (default: 200)--edge-canny-high: Upper threshold for Canny edge detection (default: 255)--edge-dilation-size: Dilation size for edge tolerance (default: 2)Technical Details
The edge detection approach is based on production-proven techniques from the Salmon-Computer-Vision project for fish counting in sonar imagery. The bidirectional filtering and edge intersection logic eliminates spurious edges while preserving true fish boundaries.
Visual Interpretation
Users can now easily identify fish by looking for yellow regions in the output videos, where:
Testing
Manually tested with sample ARIS sonar videos. The green channel successfully highlights fish edges, and yellow regions correspond to confirmed fish detections.