Skip to content

Daytime filter is not applied to the time period (line) graph #604

Description

@martijn-bollen

Summary

The daytime (day-period) filter is not affecting the line graph (observations through time) displayed in the interface. When a day-period (Dawn / Day / Dusk / Night) or freeform arc is selected, the observation counts represented in the line graph (time period filter in the bottomright pane) remain unchanged, rather than updating to reflect only the observations that fall within the selected daytime window. This is in line with #568

Expected

The line graph should update to reflect the active daytime filter — i.e., it should only count and visualize observations whose capture time falls within the selected day-period. This way, the line graph matches how other parts of the interface respond to the daytime selector.

Actual

Currently, the line graph ignores the daytime filter and always renders the full-day observation totals, regardless of filter selection.

Cause

It appears that the logic driving the line graph is missing support for the timeRange parameter (passed via the daytime/day-period filter), as is already the case with the species distribution counts (see linked issue below). As a result, the daytime filtering has no effect on this visualization.

Fix direction

Update the line graph (observations through time) query to accept and apply the active timeRange (or relevant filter) from the renderer, similar to what is required for species distribution counts. Utilize the same time range normalization and filtering logic to ensure consistency and correctness in the data displayed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions