Repository navigation
feat(deployments): mark deployment start and end on activity sparklines - #639
Merged
Merged
Conversation
✅ Deploy Preview for lucent-yeot-0cb408 canceled.
|
A row's sparkline could not distinguish a camera that was not running from one that ran and saw nothing. Two faint vertical marks now sit behind each bars/heatmap sparkline at the deployment's first and last bucket edges, turning blue on hover or selection; section headers show the union of their children. The cursor pill says 'not deployed' instead of '0 obs' when the hovered empty bucket falls outside the selected deployment's window. Line mode is left untouched because the marks fight the smoothed curve.
…ployed' to the selected row Indented child rows shifted their sparkline 28px right of the header's date axis and the hover ruler, so the crosshair mapped to the wrong bucket on grouped deployments and the pill could say 'not deployed' over a cell with a bar. The indent is now absorbed by the name column. The 'not deployed' wording is also only used while the cursor is over the selected row itself; over any other row the pill keeps its plain count, since it always describes the selected deployment.
Chouffe
force-pushed
the
arthur/deployment-coverage-hairline
branch
from
September 23, 2026 12:33
0a4a4bc to
f837ce4
Compare
Collaborator
Author
|
would love your review @ioRekz |
…erage-hairline # Conflicts: # src/renderer/src/deployments.jsx # src/renderer/src/deployments/groupDeployments.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coverage.jssnaps dates outward to bucket edges (half-open buckets, open-ended on a missing date, null on unparseable or out-of-grid input). Renderer-only; no IPC or query changes, the activity payload already carrieddeploymentStart/deploymentEnd.Test plan
node --test test/renderer/*.test.js: 257 pass (16 new: bucket snapping, boundary dates, open-ended ranges, unparseable dates, group union incl. order-independence with bad dates)