Skip to content

fix: replace hardcoded localhost with production domain in invitation…#3

Merged
earzalien merged 3 commits intomainfrom
staging
Mar 7, 2026
Merged

fix: replace hardcoded localhost with production domain in invitation…#3
earzalien merged 3 commits intomainfrom
staging

Conversation

@earzalien
Copy link
Owner

@earzalien earzalien commented Mar 7, 2026

… link


Summary by cubic

Use the CLIENT_URL environment variable to build trip invitation links instead of the hardcoded http://localhost:3000, fixing broken invites in production. If CLIENT_URL is missing, the API now throws a clear error to prevent generating invalid links.

Written for commit a3bbbe9. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="server/src/modules/invitation/invitationActions.ts">

<violation number="1" location="server/src/modules/invitation/invitationActions.ts:105">
P2: Avoid hardcoding the frontend domain in code; build invitation links from configuration so deployments across environments don’t require code changes.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="server/src/modules/invitation/invitationActions.ts">

<violation number="1" location="server/src/modules/invitation/invitationActions.ts:105">
P2: Guard against missing CLIENT_URL; otherwise invitations can return `undefined/...` URLs when the env var is not configured.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@earzalien earzalien merged commit 6c48d7c into main Mar 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant