Repository navigation
phpmailer: composer require ^6.9, remove vendor-legacy/ - #33
Merged
Merged
Conversation
PHPMailer was vendored in packages/cms-core/vendor-legacy/phpmailer/ since Plan 01 B16 (legacy cleanup). Replace with a proper Composer dependency now that everything else in cms-core has moved to PSR-4. Mailer.php no longer has the require_once — PHPMailer is autoloaded by Composer. PHPMailer FQN imports already used the full namespace so no other changes needed. vendor-legacy/ directory removed entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPMailer v6.12.0 via Composer i.p.v. vendored. Geen functional change in Mailer. Tests 328 totaal, alle groen.