Skip to content

feat: support optional display names for bridge handlers - #94

Merged
easyhooon merged 1 commit into
mainfrom
feat/handler-display-names
Sep 2, 2026
Merged

easyhooon merged 1 commit into
mainfrom
feat/handler-display-names

Conversation

@easyhooon

Copy link
Copy Markdown
Owner

Summary

  • add backward-compatible display-name overloads for string and protobuf requests
  • persist display names separately and render/search them across the inspector UI and notifications
  • export display names as a separate text/JSON field and document the API in English and Korean
  • cover core API compatibility, persistence, presentation, export, and noop behavior

Testing

  • ./gradlew check
  • npm run build -- --webpack (documentation)

Fixes #93

안정적인 handlerName과 선택적 displayName을 분리해 저장하고 표시한다.
기존 인터셉터 시그니처와 noop API 호환성을 유지한다.
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 9482d4ff-9e39-4720-ad96-38a114d28377

📥 Commits

Reviewing files that changed from the base of the PR and between 7252b58 and 046609f.

📒 Files selected for processing (26)
  • README.md
  • dari-core/src/commonMain/kotlin/com/easyhooon/dari/MessageEntry.kt
  • dari-core/src/commonMain/kotlin/com/easyhooon/dari/interceptor/DariInterceptor.kt
  • dari-core/src/commonMain/kotlin/com/easyhooon/dari/interceptor/ProtobufDariInterceptor.kt
  • dari-core/src/commonTest/kotlin/com/easyhooon/dari/MessageEntryTest.kt
  • dari-core/src/commonTest/kotlin/com/easyhooon/dari/PublicApiSmokeTest.kt
  • dari-noop/src/test/kotlin/com/easyhooon/dari/DariNoopApiTest.kt
  • dari/src/main/kotlin/com/easyhooon/dari/Dari.kt
  • dari/src/main/kotlin/com/easyhooon/dari/HandlerPresentation.kt
  • dari/src/main/kotlin/com/easyhooon/dari/data/local/DariDatabase.kt
  • dari/src/main/kotlin/com/easyhooon/dari/data/local/MessageEntity.kt
  • dari/src/main/kotlin/com/easyhooon/dari/export/DariExporter.kt
  • dari/src/main/kotlin/com/easyhooon/dari/export/ExportableMessage.kt
  • dari/src/main/kotlin/com/easyhooon/dari/interceptor/DefaultDariInterceptor.kt
  • dari/src/main/kotlin/com/easyhooon/dari/notification/DariNotification.kt
  • dari/src/main/kotlin/com/easyhooon/dari/ui/DariActivity.kt
  • dari/src/main/kotlin/com/easyhooon/dari/ui/DariDetailActivity.kt
  • dari/src/main/kotlin/com/easyhooon/dari/ui/components/MessageListItem.kt
  • dari/src/test/kotlin/com/easyhooon/dari/HandlerPresentationTest.kt
  • dari/src/test/kotlin/com/easyhooon/dari/data/local/MessageEntityTest.kt
  • dari/src/test/kotlin/com/easyhooon/dari/export/DariExporterTest.kt
  • dari/src/test/kotlin/com/easyhooon/dari/export/ExportableMessageTest.kt
  • documentation/content/docs/interceptor.mdx
  • documentation/content/docs/ko/interceptor.mdx
  • documentation/content/docs/ko/protobuf.mdx
  • documentation/content/docs/protobuf.mdx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@easyhooon
easyhooon merged commit f58a57d into main Sep 2, 2026
4 checks passed
@easyhooon
easyhooon deleted the feat/handler-display-names branch September 2, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support optional display names for bridge handlers

1 participant