Skip to content

Scrollbox fixes #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
midlik wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Scrollbox fixes #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aad61f
nightingale-scrollbox: relax DOMPurify sanitization to allow custom e…
midlik Jul 1, 2026
57a0d3c
nightingale-scrollbox: avoid double unregistering error when the whol…
midlik Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nightingale-scrollbox/src/nightingale-scrollbox-item.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class NightingaleScrollboxItem<TData> extends NightingaleElement {

private setContent(content: string | null | undefined) {
if (content === undefined || content === null) return;
this.innerHTML = DOMPurify.sanitize(content);
this.innerHTML = DOMPurify.sanitize(content, { CUSTOM_ELEMENT_HANDLING: { tagNameCheck: /.*/, attributeNameCheck: /.*/, allowCustomizedBuiltInElements: true } });
}

/** Set or remove "onRegister" callback function. Also run this callback function if the item is already registered (i.e. in "new", "visible", or "hidden" state). */
Expand Down
4 changes: 2 additions & 2 deletions packages/nightingale-scrollbox/src/nightingale-scrollbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@ export class NightingaleScrollbox<TData> extends NightingaleElement {
unregister: () => this.unregister(item),
};
}
/** Remove a scrollbox item and run "onUnregister" callback on it. This method is called automatically when a `nightingale-scrollbox-item` element is removed from the `nightingale-scrollbox` element. */
/** Remove a scrollbox item and run "onUnregister" callback on it. Do nothing if the item is not registered. This method is called automatically when a `nightingale-scrollbox-item` element is removed from the `nightingale-scrollbox` element. */
unregister(item: NightingaleScrollboxItem<TData>) {
if (!this._items.has(item)) throw new Error(`Cannot unregister item ${item} because it is not registered.`)
if (!this._items.has(item)) return;
this._items.delete(item);
this.observer?.unobserve(item);
item.unregister();
Expand Down
3 changes: 2 additions & 1 deletion stories/19.NightingaleScrollbox/NightingaleScrollbox.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import { html } from "lit-html";
import { range } from "lodash-es";
import "../../packages/nightingale-navigation/src/index";
import "../../packages/nightingale-scrollbox/src/index";
import { NightingaleScrollbox, NightingaleScrollboxItem } from "../../packages/nightingale-scrollbox/src/index";
import type { NightingaleScrollbox, NightingaleScrollboxItem } from "../../packages/nightingale-scrollbox/src/index";
import "../../packages/nightingale-track/src/index";


export default {
Expand Down