Skip to content

Structure table - #178

Merged
Swaathik merged 6 commits into
mainfrom
structure-table
Jul 10, 2026
Merged

Structure table#178
Swaathik merged 6 commits into
mainfrom
structure-table

Conversation

@Swaathik

@Swaathik Swaathik commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Purpose

Refactor structure table

Approach

Needs type update from Nightingale for AlphaFold
ebi-webcomponents/nightingale#332

Testing

What test(s) did you write to validate and verify your changes?

Visual changes

add screenshots/recordings if applicable

Checklist

  • My PR is scoped properly, and "does one thing only"
  • I have reviewed my own code
  • I have checked that linting checks pass and type safety is respected
  • I have checked that tests pass and coverage has at least improved, and if not explained the reasons why
  • If needed, the changes have been previewed by all interested parties.

Comment thread src/protvista-uniprot-structure.ts Outdated
Comment on lines +575 to +587
// const beaconsAFData = beaconsData.filter(
// ({ source }) => source === 'AlphaFold DB'
// );
// const beaconsNonAFData = beaconsData.filter(
// ({ source }) => source !== 'AlphaFold DB'
// );

// const uniqueAFData = [
// ...new Map(
// // The order of the spread is important as we want to prioritise AF data from AF predictions API over 3DBeacons
// [...beaconsAFData, ...afData].map((obj) => [obj.id, obj])
// ).values(),
// ];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this to stick around or can it be deleted?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it. It is not needed anymore

@Swaathik
Swaathik merged commit 7f9b928 into main Jul 10, 2026
3 checks passed
@Swaathik
Swaathik deleted the structure-table branch July 10, 2026 08:45
@dlrice dlrice mentioned this pull request Jul 31, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants