Repository navigation
Release 3.0.51 - #92
Merged
Merged
Conversation
Bumps the version and records what landed after 3.0.50. The beacon now observes the audience collection rather than only the first audience a process happened to see (#91). That is where the account-wide count comes from, and without it coverage was unanswerable -- we could say how many audiences we held and never how many existed, which is what made a large contact fall on a real account impossible to diagnose. And it reads the account's billing arrangement off the account root (#90), which separates an account paying for a plan from one paying nothing. Not the plan tier; nothing on that response carries it. Both are passive. Neither adds a request, spends quota, or changes what any call sends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump and changelog. No code changes.
What it releases
#91 — the audience collection.
observeList()kept only the first audience a process saw, so an installation with several store views described one of them and nothing said how many existed. Coverage was a tautology, and the question that matters — has an audience nobody looked at changed — could not be asked.The collection answers both halves in one response, and it is already fetched when the admin offers the audience dropdown, so nothing new is requested.
The roster is keyed by audience id, so a later reading completes an earlier one and a repeated id is impossible by construction. The account-wide count is never capped: a truncated roster beside an intact count still answers the coverage question, while losing the count loses the only figure nothing else can supply. The roster is bounded by both entry count and serialised size, trimmed one entry at a time.
#90 — the account's billing arrangement.
pricing_plan_typesits on the account root beside the four fields already read there, and separates an account paying for a plan from one paying nothing. Kept as the string the API returns rather than mapped to a fixed set. Not the plan tier — nothing on that response carries it, and the docblock says so, because that is the misreading the field invites.Both passive: no additional call, no quota, nothing added to any request.
tools/no-deprecated-calls.php: 64 files, 0 findings.Order
This is tagged ahead of the extension release deliberately, so the extension can raise its library floor to this version rather than pointing at a tag that does not exist yet. The ordering question that prompted it has been settled separately: a missing count is stored and displayed as unknown rather than zero, so neither order produces a misleading reading.