Repository navigation
Release 3.0.53 - #97
Merged
Merged
Conversation
Bumps the version and records what landed after 3.0.52. One fix, and it is one this library owed its oldest installations (#96). `saveNotification()` is the module's, it arrived there in 103.4.65 on 2024-12-03, and the calls to it landed here the day after -- so every installation whose module predates that version has been fataling on every API call since 3.0.42, on the answer and on the failure alike. Composer cannot express the pairing that would have caught it: a library cannot require a minimum module version, and the module's own constraint is a floor with no ceiling, so `composer update` hands an old module the newest library published. The guards are what let such a host simply not be told. Nothing changes for a module that has the method. Same payload, same call, same order, and a current installation cannot tell this release from the last by its behaviour -- which is the point: what it changes is what happens on the installations we cannot see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump and changelog for the guard fix in #96.
The fix reaches installations whose module predates 103.4.65, where the unguarded
saveNotification()call has been a fatal on every API call since 3.0.42. Nothing changes for a module that has the method.No source changes in this PR:
composer.jsonandCHANGELOG.mdonly, as usual for a release.