simplify auto_base with C++17 parameter pack expansion in using#194
Open
simplify auto_base with C++17 parameter pack expansion in using#194
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
==========================================
- Coverage 89.91% 89.90% -0.02%
==========================================
Files 125 125
Lines 5812 5816 +4
==========================================
+ Hits 5226 5229 +3
- Misses 586 587 +1 ☔ View full report in Codecov by Sentry. |
42f9708 to
2ad85f0
Compare
this shortens the name of some tags, from adm::detail::ParameterTraits<...>::SomeTag to just SomeTag in most of the places where this is used, an unused tag type was created anyway (sometimes with the wrong name), so using that is probably clearer
the minimum cmake version is now 3.8, which is still ancient
2ad85f0 to
3642d45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo:
no, this is still required. one possible improvement would be to flatten the list of parameters inHasParametersImpl, so thatHasParameters<A, HasParameters<B, C>>(as produced byVariantParameter) is turned intoHasParameters<A, B, C>, producing fewerCombineclasses.FlagsthingVariantParameterusesHasParameters, so thehasetc. methods are overloaded, which can't be detected without knowing the parameter types