drop LinkedList, the covered wrapper the crate's own lints forbid it a fixture for - #229
Merged
Conversation
…a fixture for `LinkedList` sat on the sequence-wrapper list, covered by name only: clippy's `linkedlist` lint, denied through pedantic, forbids declaring a field of the type in this crate's own tests, so nothing could ever exercise the macro expanding over a real one. A support no fixture can prove is a promise the suite cannot keep, and the lint's own rationale — use `Vec` — applies to this crate's consumers as much as to this crate. A `LinkedList<T>` field is refused now rather than silently unlisted, through the same rejection seam the other refused std types answer from, so the field, alias, brand-inner and filling positions all get the refusal spanned on their own subject. The message is its own, not the deny-list's: that list's wording says serde implements neither trait, which is false here — serde writes a `LinkedList` as the same JSON array `Vec` writes, which is exactly why nothing on the wire tells the two apart and only one spelling is described. The message names both rewrites, `Vec<T>`, or `VecDeque<T>` where values are pushed at both ends. The three near-identical written-name walkers folded into one that takes the predicate, so the new refusal did not add a fourth copy of a forty-arm match. just check, just quick, just lint-all across all 68 toggles, and the test powerset across all 68 in four partitions — all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinkedListsat on the sequence-wrapper list, covered by name only: clippy'slinkedlistlint, denied through pedantic, forbids declaring a field of thetype in this crate's own tests, so nothing could ever exercise the macro
expanding over a real one. A support no fixture can prove is a promise the
suite cannot keep, and the lint's own rationale — use
Vec— applies to thiscrate's consumers as much as to this crate.
A
LinkedList<T>field is refused now rather than silently unlisted, throughthe same rejection seam the other refused std types answer from, so the field,
alias, brand-inner and filling positions all get the refusal spanned on their
own subject. The message is its own, not the deny-list's: that list's wording
says serde implements neither trait, which is false here — serde writes a
LinkedListas the same JSON arrayVecwrites, which is exactly why nothingon the wire tells the two apart and only one spelling is described. The message
names both rewrites,
Vec<T>, orVecDeque<T>where values are pushed at bothends.
The three near-identical written-name walkers folded into one that takes the
predicate, so the new refusal did not add a fourth copy of a forty-arm match.
just check, just quick, just lint-all across all 68 toggles, and the test
powerset across all 68 in four partitions — all green.