React print performance adjustment#2700
Merged
carlobeltrame merged 4 commits intoJul 6, 2022
Merged
Conversation
usu
reviewed
May 8, 2022
9 tasks
BacLuc
approved these changes
Jun 9, 2022
Member
Author
Meeting discussionIn order to get react printing to work again, we can continue with this PR, now that react-pdf fixed itself and is on the way to complete Vite compatibility. After that, #2829 should be fixed. |
Fixes the open todo from ecamp#2571 (comment)
…that it's available
carlobeltrame
force-pushed
the
react-print-performance-adjustment
branch
from
ad0cb7c to
b9966db
Compare
pmattmann
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #2571
I added an implementation for Period#getContentNodes, because in react-print, we don't have access to the API root at the moment, and I find it more elegant anyways. I also used this new related collection link in nuxt-print now that it is available.