Skip to content

Feature: change mail-adress #2800

Merged
pmattmann merged 9 commits into
ecamp:develfrom
pmattmann:feature/change-mail
Jun 13, 2022
Merged

Feature: change mail-adress #2800
pmattmann merged 9 commits into
ecamp:develfrom
pmattmann:feature/change-mail

Conversation

@pmattmann

@pmattmann pmattmann commented Jun 6, 2022

Copy link
Copy Markdown
Member

Bietet Funktionalität zum Ändern der eigenen Mail-Adresse

Fixes #2357

@pmattmann pmattmann force-pushed the feature/change-mail branch from 1bf4c78 to 7ac9648 Compare June 6, 2022 12:43
@pmattmann pmattmann force-pushed the feature/change-mail branch from 0dfdb1c to a020599 Compare June 6, 2022 13:52
Comment thread api/src/Entity/Profile.php Outdated
Comment thread api/src/DataPersister/ProfileDataPersister.php
Comment thread api/src/Entity/Profile.php Outdated
Comment thread api/src/Entity/Profile.php Outdated
Comment thread api/src/Entity/Profile.php Outdated
Comment thread api/src/Entity/Profile.php Outdated
Comment thread frontend/src/views/Profile.vue Outdated
Comment thread frontend/src/components/user/DialogChangeMail.vue Outdated
Comment thread frontend/src/components/user/DialogChangeMailRunning.vue Outdated
Comment thread frontend/src/views/Profile.vue
Comment thread frontend/src/components/user/DialogChangeMail.vue

@BacLuc BacLuc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, even works when you are not logged in and click on the link.
You can log in, and then you are redirected to the profile page with the spinner

Comment thread frontend/src/components/user/DialogChangeMail.vue Outdated
Comment thread frontend/src/components/user/DialogChangeMail.vue Outdated
Comment thread frontend/src/components/user/DialogChangeMail.vue
Comment thread frontend/src/components/user/DialogChangeMail.vue
@pmattmann pmattmann force-pushed the feature/change-mail branch from e27de63 to e079681 Compare June 11, 2022 09:49

@usu usu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Tested and works well for me. Small changes as per proposals below.

Comment thread frontend/src/views/Profile.vue Outdated
Comment thread frontend/src/locales/en.json Outdated
Comment thread frontend/src/locales/en.json Outdated
Comment thread frontend/src/locales/en.json Outdated
Comment thread frontend/src/locales/en.json Outdated
Comment thread frontend/src/locales/en.json Outdated
Comment thread frontend/src/locales/en.json Outdated
@usu usu mentioned this pull request Jun 12, 2022
31 tasks
@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Jun 13, 2022
@carlobeltrame

Copy link
Copy Markdown
Member

Noch zwei Szenarien die man noch testen müsste:

  • Ich erstelle mir einen neuen Account, aktiviere ihn noch nicht. Dann ändere ich (von mir aus via API wenn ich im Frontend nicht die Möglichkeit bekomme) meine Mailadresse. Komme ich dadurch in irgendeinen speziellen Zustand? Kann ich danach etwas was ich nicht können sollte? Kann ich etwas nicht, was ich können sollte?
  • Ich registriere mich via OAuth, und ändere dann meine Mailadresse. Funktioniert der OAuth Login danach noch? Passiert sonst etwas unerwartetes?

@BacLuc

BacLuc commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

You maybe have conflicts now with merged #2769

@carlobeltrame carlobeltrame left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wenn der Mail-Change bei OAuth keine unerwarteten Faxen macht ist gut für mich, merci! 👍

@pmattmann pmattmann removed the deploy! Creates a feature branch deployment for this PR label Jun 13, 2022
@pmattmann pmattmann merged commit 84684e5 into ecamp:devel Jun 13, 2022
@pmattmann pmattmann deleted the feature/change-mail branch June 13, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing email address needs to trigger confirmation email

5 participants