Skip to content

fix(api): allow null values in json schema for storyboard#2968

Closed
usu wants to merge 2 commits into
ecamp:develfrom
usu:fix/storyboard-json-schema
Closed

fix(api): allow null values in json schema for storyboard#2968
usu wants to merge 2 commits into
ecamp:develfrom
usu:fix/storyboard-json-schema

Conversation

@usu

@usu usu commented Sep 10, 2022

Copy link
Copy Markdown
Member

This is mainly to deal with migrated data, as we previously allowed null values, which now results in invalid json in the DB.

New values are coming as empty strings by default.

Not much difference for the frontend. It can deal with both null values and empty strings anyway.

@usu usu requested review from BacLuc and carlobeltrame September 10, 2022 19:24
@usu

usu commented Sep 10, 2022

Copy link
Copy Markdown
Member Author

The included frontend-fix is related to #2969

@carlobeltrame carlobeltrame left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we just throw out the migrated dev data and re-seed with correct data? I'd rather keep the json schema as specific as possible to keep future data migrations as easy as possible

@usu

usu commented Sep 11, 2022

Copy link
Copy Markdown
Member Author

Couldn't we just throw out the migrated dev data and re-seed with correct data? I'd rather keep the json schema as specific as possible to keep future data migrations as easy as possible

yes, makes sense

@usu

usu commented Sep 11, 2022

Copy link
Copy Markdown
Member Author

Superseded by #2971

@usu usu closed this Sep 11, 2022
@usu usu deleted the fix/storyboard-json-schema branch November 6, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants