fix(api): allow null values in json schema for storyboard#2968
Closed
usu wants to merge 2 commits into
Closed
Conversation
Member
Author
|
The included frontend-fix is related to #2969 |
carlobeltrame
left a comment
Member
There was a problem hiding this comment.
Couldn't we just throw out the migrated dev data and re-seed with correct data? I'd rather keep the json schema as specific as possible to keep future data migrations as easy as possible
Member
Author
yes, makes sense |
Member
Author
|
Superseded by #2971 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly to deal with migrated data, as we previously allowed null values, which now results in invalid json in the DB.
New values are coming as empty strings by default.
Not much difference for the frontend. It can deal with both null values and empty strings anyway.