feat(workers): Include GradleDefinitions in the GradleInitGenerator#3130
feat(workers): Include GradleDefinitions in the GradleInitGenerator#3130bs-ondem wants to merge 1 commit intoeclipse-apoapsis:mainfrom
GradleDefinitions in the GradleInitGenerator#3130Conversation
|
|
||
| GradleInitGenerator().generate(mockBuilder.builder, listOf(definition1, definition2)) | ||
|
|
||
| val expectedLines = listOf( |
There was a problem hiding this comment.
How about beautifying this with the
"""
...
""".trimIndent()approach?
There was a problem hiding this comment.
FYI, I've done this now also for existing code in #3153.
Extend the `GradleInitGenerator` to include repositories from `GradleDefinition`s in addition to the globally configured `MavenCentralMirror`. Override the globally configured `MavenCentralMirror` if a `GradleDefinition` uses the same URL. Signed-off-by: Onur Demirci <onur.demirci@bosch.io>
f916c5a to
b2a3717
Compare
|
@sschuberth we at Bosch are currently unsure whether the new feature (allowing |
I guess this boils down to the old question of self-contained builds vs. central configuration, which means there's no clear answer. Personally, I'm pro self-contained builds, even if that might require some repetition of global configuration in some cases. So I'd proceed as I always try in such cases: Keep it simple unless the added complexity is clearly needed. |
|
@eclipse-apoapsis/bosch Are there any plans to continue working on this? |
Extend the
GradleInitGeneratorto include repositories fromGradleDefinitions in addition to the globally configuredMavenCentralMirror. Override the globally configuredMavenCentralMirrorif aGradleDefinitionuses the same URL.