Skip to content

Add optional repository name#4802

Merged
sschuberth merged 6 commits intomainfrom
repository-name
Apr 16, 2026
Merged

Add optional repository name#4802
sschuberth merged 6 commits intomainfrom
repository-name

Conversation

@Etsija
Copy link
Copy Markdown
Contributor

@Etsija Etsija commented Apr 7, 2026

1. Adding a new repository: an optional name can be given

Screenshot from 2026-04-08 11-23-46

2. Editing repository details: you can add/modify/delete the name

Screenshot from 2026-04-08 11-25-02

3. The name (if given) is seen in the repository details page and breadcrumb

Screenshot from 2026-04-08 11-25-33

4. In product repositories table, name is also shown in case it exists

Screenshot from 2026-04-15 13-08-55

Please see the commits for details.

NOTE1: @sschuberth I didn't yet remove the repository ID - maybe @hanna-modica could tell if it's still needed for the CLI usage? We could provide with something handier for copying the URL needed for the CLI.

NOTE2: Although the API commit is marked as breaking (as it changes the API), it is not breaking as such, as the PR only adds an optional name to the GET/CREATE/UPDATE repository endpoints, and no back-filling to the database is needed.

NOTE3: This PR also resolves #1368 by relaxing the uniqueness requirement of the repositories: now triplet (product_id, url, name) must be unique, so there can be multiple repositories with the same URL inside a product if their names differ. It was also tested manually in the UI that creating a repository with the same URL and omitting the name gives is prevented:

Screenshot from 2026-04-14 06-25-06

@Etsija Etsija linked an issue Apr 7, 2026 that may be closed by this pull request
@eclipse-apoapsis eclipse-apoapsis deleted a comment from github-actions bot Apr 7, 2026
@Etsija Etsija marked this pull request as draft April 8, 2026 08:06
@Etsija Etsija force-pushed the repository-name branch from bddd969 to 29655a6 Compare April 8, 2026 08:21
@Etsija Etsija marked this pull request as ready for review April 8, 2026 08:30
@Etsija Etsija requested a review from lamppu as a code owner April 8, 2026 08:30
@Etsija Etsija enabled auto-merge April 8, 2026 08:30
Copy link
Copy Markdown
Contributor

@lamppu lamppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Etsija Etsija force-pushed the repository-name branch from 29655a6 to 6b3b091 Compare April 9, 2026 05:07
@Etsija Etsija marked this pull request as draft April 9, 2026 05:59
auto-merge was automatically disabled April 9, 2026 05:59

Pull request was converted to draft

@Etsija
Copy link
Copy Markdown
Contributor Author

Etsija commented Apr 9, 2026

I realised the repositories can still only be filtered by their URL, so I need to add support for filtering by name as well now.

@Etsija Etsija marked this pull request as ready for review April 9, 2026 06:30
@Etsija Etsija requested a review from lamppu April 9, 2026 06:30
@sschuberth
Copy link
Copy Markdown
Contributor

I haven't checked, but what about the delete confirmation? Should deletion still be confirmed by URL if a name is present, or should then (only) the name be used? Let's discuss with the team.

@Etsija
Copy link
Copy Markdown
Contributor Author

Etsija commented Apr 9, 2026

I haven't checked, but what about the delete confirmation? Should deletion still be confirmed by URL if a name is present, or should then (only) the name be used? Let's discuss with the team.

I can do either; it's URL confirmation only for now. We didn't actually discuss this with the team today, so which way do you want it, @sschuberth?

@sschuberth
Copy link
Copy Markdown
Contributor

sschuberth commented Apr 9, 2026

We didn't actually discuss this with the team today

I also forgot to ask: While this PR addresses #1599, it does not address #1368 yet (for the reason mentioned here) yet, correct? If so, the primary identifier of a repository stays to be the URL, and while that's the case, IMO also the URL should be used in the delete confirmation. Does that make sense to you as well, @Etsija?

@Etsija
Copy link
Copy Markdown
Contributor Author

Etsija commented Apr 9, 2026

We didn't actually discuss this with the team today

I also forgot to ask: While this PR addresses #1599, it does not address #1368 yet (for the reason mentioned here) yet, correct? If so, the primary identifier of a repository stays to be the URL, and until that's the case, IMO also the URL should be used in the delete confirmation. Does that make sense to you as well, @Etsija?

Yes it does.

@Etsija
Copy link
Copy Markdown
Contributor Author

Etsija commented Apr 10, 2026

@sschuberth what's the status of this PR, could it be approved now?

@sschuberth
Copy link
Copy Markdown
Contributor

@sschuberth what's the status of this PR, could it be approved now?

It changes areas of the backend code that I'd prefer others to review. I don't see a need to rush this until @mnonnenmacher is back on Monday, but of course @eclipse-apoapsis/bosch is welcome to review, too.

@Etsija Etsija force-pushed the repository-name branch 3 times, most recently from 5e4b1dd to b260f0c Compare April 10, 2026 10:51
@Etsija Etsija added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@mnonnenmacher mnonnenmacher added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@mnonnenmacher mnonnenmacher added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@mnonnenmacher mnonnenmacher added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 16, 2026
@mnonnenmacher mnonnenmacher added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@mnonnenmacher mnonnenmacher added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@mnonnenmacher mnonnenmacher added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@Etsija Etsija added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@Etsija Etsija added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@mnonnenmacher mnonnenmacher added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@mnonnenmacher mnonnenmacher added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@sschuberth sschuberth added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@Etsija Etsija added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@sschuberth sschuberth added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@sschuberth sschuberth added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 9f8fb12 Apr 16, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow custom names for repositories Relax uniqueness constraint of Repository URLs inside a Product and add optional name field for repositories

4 participants