Open
Conversation
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/ChoreographerService.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/ChoreographerService.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
| class StepResponseEvaluation { | ||
|
|
||
| private String getJsonValue(String path, String message) { | ||
| ObjectMapper objectMapper = new ObjectMapper(); |
Member
There was a problem hiding this comment.
You should @Autowire the object mapper and not instatatiate it every time when the method is called.
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
choreographer/src/main/java/eu/arrowhead/core/choreographer/service/StepResponseEvaluation.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
core-common/src/main/java/eu/arrowhead/common/database/entity/ChoreographerStep.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
core-common/src/main/java/eu/arrowhead/common/database/entity/ChoreographerStep.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
core-common/src/main/java/eu/arrowhead/common/database/entity/ChoreographerStep.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
core-common/src/main/java/eu/arrowhead/common/database/entity/ChoreographerStep.java
Outdated
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
core-common/src/main/java/eu/arrowhead/common/dto/shared/ChoreographerStepRequestDTO.java
Show resolved
Hide resolved
borditamas
reviewed
Nov 22, 2023
core-common/src/main/java/eu/arrowhead/common/database/entity/ChoreographerStep.java
Show resolved
Hide resolved
borditamas
requested changes
Nov 22, 2023
Member
borditamas
left a comment
borditamas
left a comment
There was a problem hiding this comment.
See inline comments.
Also, unit tests will need to be updated/written later to cover this new feature and you need to become an Eclipse Contributor (wiki) for the offical release.
borditamas
requested changes
Dec 8, 2023
Member
borditamas
left a comment
borditamas
left a comment
There was a problem hiding this comment.
There are still some suggestion, but looks good overall.
|
|
||
| //------------------------------------------------------------------------------------------------- | ||
| private ExecutorSelector executorSelector; | ||
|
|
Member
There was a problem hiding this comment.
Add here:
@Autowired
private StepResponseEvaluation evaluator;
|
|
||
| boolean executable = true; | ||
|
|
||
| AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(); |
Member
There was a problem hiding this comment.
Delete these stuffs:
AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext();
context.scan("eu.arrowhead.core.choreographer.servic");
StepResponseEvaluation evaluator = new StepResponseEvaluation(); //context.getBean(StepResponseEvaluation.class);
// new StepResponseEvaluation();
'''
| class StepResponseEvaluation { | ||
|
|
||
| private final Logger logger = LogManager.getLogger(StepResponseEvaluation.class); | ||
|
|
Member
There was a problem hiding this comment.
Add:
@Autowired
private ObjectMapper mapper;
| public Boolean stepOutputValue(String message, String path, String threshold) { | ||
| // if sth used is null throw exception | ||
| if (path == null || message == null || threshold == null) { | ||
| throw new NullPointerException("The arguments cannot be null"); |
Member
There was a problem hiding this comment.
Do not throw programatically throw NullPointerException. It should be thrown only in runtime when it is not intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.