Add ECDSA key support (SECP256R1)#101
Closed
itstheceo wants to merge 22 commits intoeclipse-biscuit:masterfrom
Closed
Add ECDSA key support (SECP256R1)#101itstheceo wants to merge 22 commits intoeclipse-biscuit:masterfrom
itstheceo wants to merge 22 commits intoeclipse-biscuit:masterfrom
Conversation
just want to get plumbed in and existing tests passing
itstheceo
commented
May 24, 2024
sync upstream
This implements 3rd party block generation and appending to existing tokens. It also fixes existing issues with public key interning which made deserialization of tokens with 3rd party blocks incorrect in some cases. Co-authored-by: Geoffroy Couprie <contact@geoffroycouprie.com>
Contributor
|
#104 is merged at last, and I tried to keep the conflict to a minimum, and have a similar API to what you used to sign the 3rd party blocks |
# Conflicts: # src/main/java/org/biscuitsec/biscuit/crypto/KeyPair.java # src/main/java/org/biscuitsec/biscuit/crypto/PublicKey.java # src/main/java/org/biscuitsec/biscuit/token/Biscuit.java # src/main/java/org/biscuitsec/biscuit/token/UnverifiedBiscuit.java # src/main/java/org/biscuitsec/biscuit/token/builder/parser/Parser.java # src/main/java/org/biscuitsec/biscuit/token/format/SerializedBiscuit.java # src/test/java/org/biscuitsec/biscuit/token/BiscuitTest.java
Implement 3rd party block creation (#104)
Contributor
Author
|
Updated and resolved the conflicts. Had some bumps with syncing upstream hopefully doesn't cause any issues. Would suggest squash merging this one, when it's satisfactory. |
Contributor
Author
|
@Geal rebased the remote signer branch as well, was a few touchpoints for the external signature handling which I've consolidated into the Signer class. Both branches passing again. |
Contributor
|
Great. Timing wise, we have to release the library with the public key interning fix and another fix that will come within a few days, in a minor version, then this will be merged with other API changes in a major version very soon |
Contributor
Author
|
Superseded by #108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses BouncyCastle for the provider.
There are a few outstanding todos yet to be addressed, any pointers thereand feedback in general would be greatly appreciated. Thanks!