Closed
Conversation
Contributor
|
Could you have a look at #113 ? |
Contributor
|
This PR is not outdated by #113 so I will close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the capability to create a KeyPair by providing a
Signerdelegate which knows how to sign block byte[] directly. Existing usages will infer aPrivateKeySigner, however the intended use case is for when the private key cannot be directly accessed, e.g when working with KMS in AWS. Added a test showing this use case.This PR also unifies the signing behaviour into a single file, which maybe nice before updating the implementation to the v1 spec. See the
Signerinterface.