Skip to content

Fix deserialization of root key id#112

Merged
Korbik merged 2 commits intoeclipse-biscuit:mainfrom
preuss-adam:adam/fix-reading-root-ids
Feb 11, 2025
Merged

Fix deserialization of root key id#112
Korbik merged 2 commits intoeclipse-biscuit:mainfrom
preuss-adam:adam/fix-reading-root-ids

Conversation

@preuss-adam
Copy link
Contributor

  • Fix missing root key id in construction of SerializedBiscuit.
  • Use root key id directly from SerializedBiscuit to avoid losing it when copying objects.

Copy link
Contributor

@Korbik Korbik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Is it necessary to be integrated in a fix release ? Because the next release will be a major one with some break with the API.

For a quick fix, we may need to create a new branch to release the fix and rebase the branch from the 4.0.1 tag. Let me know what you prefer.

@preuss-adam
Copy link
Contributor Author

Thanks for review. I think we just merge this now and have new release when it is appropriate.

I'm more interested in a release because of the fix to check the result of verification in: #108

@Korbik Korbik merged commit f05b52a into eclipse-biscuit:main Feb 11, 2025
@preuss-adam preuss-adam deleted the adam/fix-reading-root-ids branch February 11, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants