Java checkstyle google format migration#116

Merged

Korbik merged 46 commits intoeclipse-biscuit:mainfrom

Korbik:java_checkstyle_google_format_migration

Mar 18, 2025

Contributor

Korbik commented Mar 4, 2025 •

edited

Loading

Implementation of #110

Mix of sun_checks and Google Format

Korbik marked this pull request as draft

March 4, 2025 16:58

Korbik mentioned this pull request

Make Java implementation more idiomatic (by merging my fork) #109

Open

Contributor

KannarFr commented Mar 4, 2025

<3.

Korbik marked this pull request as ready for review

March 5, 2025 16:40

ghubstan mentioned this pull request

MVN: Spotless google-java-format #114

Merged

ghubstan reviewed

View reviewed changes

ghubstan left a comment

I see customizations of the checkstyle.xml, and take back everything I said about renaming this file google_checks.xml.

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/datalog/SymbolTable.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/format/SerializedBiscuit.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/Block.java Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/Block.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/Block.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/error/Error.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/builder/Expression.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/crypto/PublicKey.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/crypto/PublicKey.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/crypto/PublicKey.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/crypto/PublicKey.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/crypto/PublicKey.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/datalog/RuleSet.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/datalog/RunLimits.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/datalog/SymbolTable.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/Authorizer.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/Authorizer.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/Block.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/Block.java Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/error/Error.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/datalog/World.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/datalog/World.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/Authorizer.java Outdated Show resolved Hide resolved

ghubstan reviewed

View reviewed changes

src/main/java/org/biscuitsec/biscuit/token/Authorizer.java Outdated Show resolved Hide resolved

Korbik added 26 commits

March 18, 2025 06:38


          Checkstyle: design: VisibilityModifier

0ce34dc


          Checkstyle: coding: MissingSwitchDefault

995f291


          Checkstyle: whitespace cleanup

0e26dc2


          Checkstyle: whitespace: EmptyForIteratorPad

007f1ff


          Checkstyle: whitespace: OperatorWrap

85e7691


          Checkstyle: whitespace: WhitespaceAfter

6d821c7


          Checkstyle: whitespace

c669048


          Checkstyle: blocks: NeedBraces

405b54a


          Spotless Google Format application

ad20f5c


          Checkstyle: DistanceVariable Token

6d8670d


          Checkstyle: DistanteVariable Scope:getPublicKey

90b6756


          Checkstyle: DistanceVariable LogicError

a95555b


          Checkstyle: DistanceVariable Authorizer

450c010


          Checkstyle: DistanceVariable without Biscuit and Block

2e07758


          Checkstyle: VariableDeclarationUsageDistance

1719c64


          Checkstyle: naming: MethodName

2b8ab02


          Checkstyle: naming: LambdaParameterName

fb3c0b4


          Checkstyle: coding: ConstructorsDeclarationGrouping

5f0495e


          Checkstyle: coding: VariableDeclarationUsageDistance

5ae94c4


          Checkstyle: regexp: RegexpSinglelineJava

56a505e


          Checkstyle: naming: LambdaParameterName

1c495ab


          Checkstyle: naming: LocalVariableName

63eae7d


          Checkstyle: naming: MemberName

a2c0cb4


          Fix compilation errors

0573d34


          Test: apply the google rules

c683d60


          Review Feedback

98e468d

Korbik force-pushed the java_checkstyle_google_format_migration branch from 3994d45 to 98e468d Compare

March 18, 2025 05:39

Korbik added 2 commits

March 18, 2025 07:52


          Java: facts(), context(), etc.

b4ab936


          SymbolTable symbolTable

99ae668

Korbik merged commit 8923fb1 into eclipse-biscuit:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet