use pyo3 0.28.2 and support python 3.14 issue#51#52
Open
ensignavenger wants to merge 2 commits intoeclipse-biscuit:mainfrom
Open
use pyo3 0.28.2 and support python 3.14 issue#51#52ensignavenger wants to merge 2 commits intoeclipse-biscuit:mainfrom
ensignavenger wants to merge 2 commits intoeclipse-biscuit:mainfrom
Conversation
Contributor
|
The issue seems to be coming from this change https://github.com/eclipse-biscuit/biscuit-python/pull/52/changes#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R1346 Since |
Contributor
|
I see |
Author
|
Simply reverting that change to the original seems to have fixed it... is that acceptable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be messy, I tried to clean it up. It is not passing pytest... and I am not sure how to fix it. As stated in issue #51, I don't have any Rust experience. Submitting the pull request for review and feedback and maybe help of those wiser than I.