Scopes are deserialized twice#310
Merged
divarvel merged 3 commits intoeclipse-biscuit:mainfrom Sep 24, 2025
Merged
Conversation
divarvel
reviewed
Sep 15, 2025
|
|
||
| let scopes: Result<Vec<Scope>, _> = | ||
| input.scope.iter().map(proto_scope_to_token_scope).collect(); | ||
|
|
Contributor
There was a problem hiding this comment.
this will require removing the ? below, i think, since this definition shadows the previous one.
Contributor
|
i could not suggest fixes from the pr page itself, so i opened a PR on your branch: saoirse-a#1 |
fix remaining extraneous scope deserialization and leftover try operator
Contributor
Author
|
Merged in, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.