Skip to content

Quick cleanup around HelpCommand#25798

Merged
dmatej merged 10 commits into
eclipse-ee4j:masterfrom
dmatej:man
Nov 21, 2025
Merged

Quick cleanup around HelpCommand#25798
dmatej merged 10 commits into
eclipse-ee4j:masterfrom
dmatej:man

Conversation

@dmatej
Copy link
Copy Markdown
Contributor

@dmatej dmatej commented Nov 21, 2025

No description provided.

@dmatej
Removing garbage after TCK CDI execution
4838fcc 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
When interrupted, shutdown the executor asap too.
0f276fd 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
More stable ProgressStatusFailITest
08b4983 
- In fact we don't have control over the timing.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Stabilizing ThreadPoolMonitoringTest
46f86a6 
- For some reason the task count increases with big latency
- Instead I removed the sleeping from waitFor, so that one will repeat a lot.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Fixed duplicit filename suffix in the output
f6e70da 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Print all commands to decrease my confusion in Ant+Bash based tests
74aa1f0 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej added this to the 7.1.0 milestone Nov 21, 2025
@dmatej dmatej requested a review from a team November 21, 2025 18:43
@dmatej
Part of the test commented out - probably reproduces a bug in monitor…
52164eb 
…ing.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@avpinchuk
Copy link
Copy Markdown
Contributor

avpinchuk commented Nov 21, 2025 •
edited
Loading

Test ThreadPoolMonitoringTest.testDualListenerHugeAmountOfFastRequests() failed when I tried to build locally (on Windows).

@dmatej
More time for the job
b3faa6f 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
avpinchuk
avpinchuk approved these changes Nov 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@avpinchuk avpinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed test is not related to this PR.

@dmatej
Copy link
Copy Markdown
Contributor Author

dmatej commented Nov 21, 2025 •
edited
Loading

The failed test is not related to this PR.
EDIT: you are right :)

@dmatej
Removed unused import from test
ac86e08 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Quick cleanup around HelpCommand
599b147 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
Copy link
Copy Markdown
Contributor Author

dmatej commented Nov 21, 2025

Rebased to #25797

@arjantijms
Copy link
Copy Markdown
Contributor

arjantijms commented Nov 21, 2025

Test ThreadPoolMonitoringTest.testDualListenerHugeAmountOfFastRequests() failed when I tried to build locally (on Windows).

fails a lot. on macOS locally too.

@dmatej
Copy link
Copy Markdown
Contributor Author

dmatej commented Nov 21, 2025

Test ThreadPoolMonitoringTest.testDualListenerHugeAmountOfFastRequests() failed when I tried to build locally (on Windows).

fails a lot. on macOS locally too.

I tried to stabilize it, but today I gave up - you already merged the commented out code with FIXME. We will fix it in some of next versions, after we revisit management-api to make those setters for monitoring atomic rather than synchronized.

@dmatej dmatej merged commit 5c450d2 into eclipse-ee4j:master Nov 21, 2025
2 checks passed
@dmatej dmatej deleted the man branch November 21, 2025 23:55
bvfalcon pushed a commit to bvfalcon/eclipse-glassfish that referenced this pull request Apr 25, 2026
@dmatej
Merge pull request eclipse-ee4j#25798 from dmatej/man
4cebe26 
Quick cleanup around HelpCommand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OndroMih OndroMih OndroMih approved these changes

@avpinchuk avpinchuk avpinchuk approved these changes

Assignees

No one assigned

Labels

code cleaning

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dmatej @avpinchuk @arjantijms @OndroMih