Skip to content

Improvements in logging#285

Merged
dmatej merged 4 commits into
eclipse-ee4j:masterfrom
dmatej:deprecations-cleanup
Apr 21, 2026
Merged

Improvements in logging#285
dmatej merged 4 commits into
eclipse-ee4j:masterfrom
dmatej:deprecations-cleanup

Conversation

@dmatej
Copy link
Copy Markdown
Contributor

@dmatej dmatej commented Apr 11, 2026

  • I spent four days to fix the last failing tests on Corba refactoring, ORB updated to 5.0.1 glassfish#25804 comparing logs of original state and my PR in a hope I will find the last side effect I could not find.
  • I also noticed few other issues I have seen in GF in last weeks.
    • Local host name resolution was strict, localhost was not accepted as local.
    • ignorance of InterruptedException

The initialization is heavily dependent on the order of operations, part is done from GlassFish, another is sparked from setParameters method call and finished by PEORBConfigurator. I would like to make it more robust in the future, but I need to know perfectly the required order of operations.

The #288 should be merged first!

@dmatej dmatej added this to the 5.1.0 milestone Apr 11, 2026
@dmatej dmatej requested a review from a team April 11, 2026 16:25
@dmatej dmatej force-pushed the deprecations-cleanup branch from 196add5 to fa2994d Compare April 15, 2026 17:48
@dmatej dmatej changed the title IOR is referred in API, must be exported too IOR is referred in API, must be exported too, improvements in logging Apr 15, 2026
@dmatej
Copy link
Copy Markdown
Contributor Author

dmatej commented Apr 17, 2026

@pzygielo Could you please review this? I would then continue with some automated cleanup steps in another PRs:

  • Code formatting
    • Running script just like on other projects, removing trailing spaces and tabs from sources.
    • Adding @Override annotations (make refactoring a lot safer, breaks the build when we forget about children)
    • Formatting imports (just like on GlassFish)
    • I would probably stop here, the rest must be done with manual changes. Not sure with that, some parts are really hard to read as whitespaces and new lines are nearly random in some files. Maybe it would be better to do that before we make other important changes.

Then ...

  • Then we would release 5.1.0
  • Then we would remove Applet references as they are not available in Java 26
  • Then we would integrate 5.1.0 to GlassFish 8 and GlassFish 7.1.1
  • Then we would start 6.0.0-SNAPSHOT
  • Then we would remove SecurityManager references as we already removed them in GF8
    • That would probably break TCK for GlassFish 7 so GF7 will stay with 5.x.x forever.

GF8+ will also do more iterations in the direction of eclipse-ee4j/glassfish#25804 to simplify the initialization of ORB. At this moment I don't know if it will need more changes in this project, but it is possible.

Finally this project is not in so bad shape as I originally thought, but ORB initialization is quite complex and was made even more complex and obfuscated in GlassFish. The cause is that components spark initialization of other components and they depend on each other, on properties set for each other, so the sequence must be perfectly controlled. Some runtime components are in this library, some are in GlassFish, and the hell is open.

Copy link
Copy Markdown
Contributor

@pzygielo pzygielo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not looked at ORBImpl yet.

Comment thread orbmain/src/main/java/com/sun/corba/ee/impl/misc/ORBUtility.java Outdated
Comment thread orbmain/src/main/java/com/sun/corba/ee/impl/orb/ORBConfiguratorImpl.java Outdated
Comment thread orbmain/src/main/java/com/sun/corba/ee/impl/resolver/LocalResolverImpl.java Outdated
Comment thread orbmain/src/main/java/module-info.java
Comment thread orbmain/src/main/java/module-info.java Outdated
@dmatej dmatej changed the title IOR is referred in API, must be exported too, improvements in logging Improvements in logging Apr 19, 2026
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
dmatej added 3 commits April 19, 2026 15:57
…nnotations

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- added toStringMethods
- added loggers
- ignored exceptions moved to addSuppressed

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej force-pushed the deprecations-cleanup branch from a9e885d to 362396c Compare April 19, 2026 14:02
@dmatej dmatej requested a review from pzygielo April 19, 2026 14:03
@dmatej dmatej merged commit 82ea943 into eclipse-ee4j:master Apr 21, 2026
2 checks passed
@dmatej dmatej deleted the deprecations-cleanup branch April 21, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants