Narrow support for stability#380
Merged
Merged
Conversation
|
Can one of the admins verify this patch? |
ivargrimstad
approved these changes
Apr 20, 2026
Member
|
LGTM |
There was a problem hiding this comment.
Pull request overview
This PR narrows the supported runtime/Java/Jakarta EE combinations to avoid generating unstable or unsupported projects, and updates CI to reflect those constraints.
Changes:
- Disable additional runtime selections in the UI for known-incompatible Jakarta EE / Java SE / Docker combinations (GlassFish, Payara, TomEE, WildFly).
- Add archetype-side validation and Dockerfile suppression to enforce (or warn about) unsupported combinations during generation.
- Adjust the archetype template to select an older WildFly version when generating EE 10 projects on Java SE 11, and update GitHub Actions workflow action versions + expected messages.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/src/main/java/org/eclipse/starter/ui/Project.java | Disables specific runtimes for additional Jakarta/Java/Docker combinations in the UI selector logic. |
| archetype/src/main/resources/META-INF/archetype-post-generate.groovy | Adds validation failures for unsupported runtime/Java combos and removes Dockerfile with warnings for unsupported Docker combos. |
| archetype/src/main/resources/archetype-resources/pom.xml | Chooses WildFly 29 for EE10 when generating with Java 11; otherwise keeps WildFly 38. |
| .github/workflows/nightly.yml | Updates actions to v5 and adjusts nightly archetype runs/assertions for new validation/warning behavior. |
| .github/workflows/main.yml | Updates actions to v5 for the main build workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mvn archetype:generate -DinteractiveMode=false -DaskForDefaultPropertyValues=false -DarchetypeGroupId=org.eclipse.starter -DarchetypeArtifactId=jakarta-starter -DarchetypeVersion=2.8.0-SNAPSHOT -DjakartaVersion=9.1 -Dprofile=web -DjavaVersion=21 -Druntime=glassfish -DoutputDirectory=app/glassfish -Dgoals="clean package" | ||
| rm -rf app/glassfish | ||
| rm -f mvn_output.txt | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.