[682] Correct the fix for 670 and return the type if the type has alr…#683
Open
jamezp wants to merge 2 commits into
Open
[682] Correct the fix for 670 and return the type if the type has alr…#683jamezp wants to merge 2 commits into
jamezp wants to merge 2 commits into
Conversation
…eady been resolved. Signed-off-by: James R. Perkins <jperkins@ibm.com>
KyleAure
reviewed
Dec 8, 2025
KyleAure
left a comment
KyleAure
left a comment
Member
There was a problem hiding this comment.
This fix looks good.
I think all we are missing from the tests are appropriate de-serialization testing for the same scenario. This looks like common practice in this test class so I added those suggestions below.
Co-authored-by: Kyle Aure <KyleJAure@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eady been resolved.
resolves #682