Implemented a node placer using Walker's algorithm in ELK Layered#1149
Draft
stu241636 wants to merge 1 commit intoeclipse-elk:masterfrom
Draft
Implemented a node placer using Walker's algorithm in ELK Layered#1149stu241636 wants to merge 1 commit intoeclipse-elk:masterfrom
stu241636 wants to merge 1 commit intoeclipse-elk:masterfrom
Conversation
Contributor
Author
|
The following examples are still problematic: Dangling nodes, which fundamentally also do not construct a tree, but which contain no cycles, are placed on top of each other: |
| for (Layer l : graph.getLayers()) { | ||
| List<LNode> nodes = l.getNodes(); | ||
| for (LNode n : nodes) { | ||
| LEdge[] edges = Iterables.toArray(n.getOutgoingEdges(), LEdge.class); |
Contributor
There was a problem hiding this comment.
If I read the message correctly, the second argument of toArray must be an LEdge[]?
ERROR] Line 130: The method toArray(Iterable<? extends T>, T[]) in the type Iterables is not applicable for the arguments (Iterable<LEdge>, Class<LEdge>)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.