Conversation
- Migrate the client workspace from Yarn 1.x + Lerna to a pnpm workspace (pnpm-workspace.yaml, pinned 'packageManager', and an 'only-allow pnpm' preinstall guard) - Replace lerna-based publish/clean/index scripts with pnpm '-r' and 'glsp releng publish' commands - Declare previously-phantom dependencies explicitly and use the 'workspace:*' protocol for the in-repo @eclipse-glsp/ide reference, as pnpm's strict node_modules layout requires - Update GitHub Actions (ci/codeql/publish) and the Jenkins pipeline to install, build, and cache with pnpm - Remove yarn.lock and lerna.json; add pnpm-lock.yaml - Update README/AGENTS docs and VS Code tasks to reference pnpm Also: - Add a 'fix' client fix-and-verify skill Part of: eclipse-glsp/glsp#1636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Migrates the
clientworkspace from Yarn 1.x + Lerna to pnpm.pnpm-workspace.yaml, pinnedpackageManager, and anonly-allow pnpmpreinstall guard)publish/clean/generate:indexscripts withpnpm -randglsp releng publishcommandsworkspace:*protocol for the in-repo@eclipse-glsp/idereference,as pnpm's strict
node_moduleslayout requiresinstall, build, and cache with pnpm
yarn.lockandlerna.json; addpnpm-lock.yamlAlso:
fixclient fix-and-verify skillPart of: eclipse-glsp/glsp#1636
How to test
ci checks need to pass
CI (ci/codeql/publish) and the Jenkins pipeline run green with pnpm
Follow-ups
Changelog