Add project-only reference search scope - #3850
Conversation
|
Can one of the admins verify this patch? |
|
That's super great @mielientiev ! Thanks so much to have worked on this issue. It will speed up the MCP Server that I am working on it. |
|
@datho7561 please review the PR. Thanks! |
|
@angelozerr were you hoping for the new scope to be used anywhere, or were you planning on doing that yourself somewhere through an extension? |
|
No I would like to use JDT.LS. My plan is to manage settings.json like vscode does to call JDT.LS with vscode java settings. In other words if user will set settings.json with projectOnly (for their project in vscode), my JDT.LS wiill use it. |
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Code looks good and tests pass. The search scope currently isn't being used anywhere outside of the tests, so I'd appreciate a follow up from Angelo for what his specific plan is.
@mielientiev Do you mind signing the ECA? Unfortunately, we can't accept the PR until you've done that.
When this PR will be merged, is there a way to download jdtls with this feature? |
There will be a nightly build here: https://download.eclipse.org/jdtls/snapshots |
That's super great! Once it will be available I will try it and give you feedback. Thanks @datho7561 ! |
|
@datho7561 done! |
|
@datho7561 please review when you have time |
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Sorry it took so long to review properly. It's looking pretty good, and it's a very good performance boost for eg. looking for all occurances of System.out.println in a project. Found another spot where I think it'd be helpful to apply the setting.
I'll put up a quick PR in vscode-java for the client side changes necessary to adopt this, which should make it easier to try out for anyone whose curious.
|
The most recent commit looks reasonable to me, but, I'm not as familiar with this project and @datho7561 is busy today. Looks safe enough to trigger the workflows. @shin19991207 If you're not busy, feel free to comment if the most recent commit looks reasonable. |
|
I think this PR addresses the original issue, and the changes look good to me. I'm +1 on it. I'm also not deeply familiar with this project either 😄, though, so it may still be worth waiting for David’s review? |
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Ihor!
See eclipse-jdtls/eclipse.jdt.ls#3850, this is the client side changes needed to adopt that PR. Signed-off-by: David Thompson <davthomp@redhat.com>
See eclipse-jdtls/eclipse.jdt.ls#3850, this is the client side changes needed to adopt that PR. Signed-off-by: David Thompson <davthomp@redhat.com>
6 participants
Fixes #3821.
When
projectOnlyis enabled, reference searches include workspace sources, tests, and referenced projects, while excluding external libraries and the JDK. The existing behavior remains unchanged by default.In a small project benchmark, some reference searches were approximately 5x to 15x faster:
all: ~27.4sprojectOnly: ~1.9s