nit: more spotbugs fixes#183
Merged
Merged
Conversation
Contributor
Author
|
brings us from 394 -> 390 |
kgibm
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix four spotbugs issues:
Node.attributeNamewas never written to, always stayed null -> remove the attributeName field, which meansdecorateWithAttributeNameis never used (all class private), and the codepath can be cleaned up.LeakHunterQueryreuses the Map.Entry object which might be reused -> reconstruct a new Map Entry.resolveIsDaemonreturns Boolean, which might be auto-unboxed tobooleanby caller and trigger a NPE -> Annotating @CheckForNulls ensures call site is validated to check that it is null before using.Value stored to
tt1which was never read -> Shuffle things around so scope is more natural/clear.