Expose explicit reset APIs for all Lazy-backed caches in OpcUaClient#1710
Merged
kevinherron merged 3 commits intomainfrom Feb 26, 2026
Merged
Expose explicit reset APIs for all Lazy-backed caches in OpcUaClient#1710kevinherron merged 3 commits intomainfrom
OpcUaClient#1710kevinherron merged 3 commits intomainfrom
Conversation
Co-authored-by: kevinherron <340273+kevinherron@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add reset methods for Lazy instances in OpcUaClient
Expose explicit reset APIs for all Lazy-backed caches in Feb 26, 2026
OpcUaClient
kevinherron
requested changes
Feb 26, 2026
Contributor
kevinherron
left a comment
There was a problem hiding this comment.
OpcUaClientResetMethodsTest is unnecessary, remove it.
Co-authored-by: kevinherron <340273+kevinherron@users.noreply.github.com>
Contributor
Author
Done in 88cb7a1 — I removed |
kevinherron
approved these changes
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request exposes public reset methods for all Lazy-backed cache fields in OpcUaClient, providing explicit cache invalidation APIs that were previously missing. The changes enhance the public API surface by allowing external consumers to explicitly invalidate caches when needed.
Changes:
- Added 6 new public reset methods (
resetOperationLimits(),resetDynamicDataTypeManager(),resetDynamicEncodingContext(),resetDataTypeTree(),resetObjectTypeTree(),resetVariableTypeTree()) - Updated existing internal reset call sites to use the new public methods for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpcUaClienthad severalLazy-backed cached fields without a corresponding public reset API. This change makes cache invalidation explicit and complete by adding public reset methods for everyLazyfield on the client.API surface: add missing reset methods for all
LazycachesresetOperationLimits()resetDynamicDataTypeManager()resetDynamicEncodingContext()resetDataTypeTree()resetObjectTypeTree()resetVariableTypeTree()Internal consistency: route existing invalidation paths through new APIs
read*Tree(),readOperationLimits(), factory setters), so behavior remains aligned while exposing the same invalidation controls externally.> [!WARNING]
>
>
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.