Skip to content

Make header logo alt text configurable via branding config #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredgalanis merged 1 commit into from
Aug 19, 2026
Merged

Make header logo alt text configurable via branding config #1349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/controllers/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ export default class ApplicationController extends Controller {
return this.staticConfig?._config?.branding?.logo ?? '';
}

get logoAlt(): string {
return this.staticConfig?._config?.branding?.logoAlt ?? 'Logo';
}

get homepage(): string {
return this.staticConfig?._config?.branding?.homepage ?? '';
}
Expand Down
1 change: 1 addition & 0 deletions app/mirage/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ export default function (config: Record<string, unknown> & { models?: Record<str
branding: {
homepage: 'https://www.eclipse.org/org/foundation/',
logo: '/app/ef/eclipse_foundation_logo_wo/EF_WHT-OR_png.png',
logoAlt: 'Eclipse Foundation',
favicon: 'favicon.ico',
stylesheet: '/app/branding.css',
overrides: '/app/branding-overrides.css',
Expand Down
1 change: 1 addition & 0 deletions app/services/app-static-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export interface BrandingConfig {
stylesheet?: string;
overrides?: string;
logo?: string;
logoAlt?: string;
homepage?: string;
contactUrl?: string;
pages?: Record<string, string>;
Expand Down
2 changes: 1 addition & 1 deletion app/templates/application.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ interface Signature {
<img
id='brand-logo'
src='{{@controller.logoUri}}'
alt='Logo'
alt={{@controller.logoAlt}}
class='nav-item d-sm-down-none pull-right brand-logo pr-0'
/>
</a>
Expand Down
1 change: 1 addition & 0 deletions public/app/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"branding": {
"homepage": "https://www.eclipse.org/org/foundation/",
"logo": "/app/ef/eclipse_foundation_logo_wo/EF_WHT-OR_png.png",
"logoAlt": "Eclipse Foundation",
"favicon": "favicon.ico",
"stylesheet": "/app/branding.css",
"overrides": "/app/branding-overrides.css",
Expand Down
1 change: 1 addition & 0 deletions public/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"branding": {
"homepage": "https://www.eclipse.org/org/foundation/",
"logo": "ef/eclipse_foundation_logo_wo/EF_WHT-OR_png.png",
"logoAlt": "Eclipse Foundation",
"favicon": "favicon.ico",
"stylesheet": "/app/branding.css",
"overrides": "/app/branding-overrides.css",
Expand Down
1 change: 1 addition & 0 deletions vite.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export default defineConfig({
branding: {
homepage: 'https://www.eclipse.org/org/foundation/',
logo: '/app/ef/eclipse_foundation_logo_wo/EF_WHT-OR_png.png',
logoAlt: 'Eclipse Foundation',
favicon: 'favicon.ico',
stylesheet: '/app/branding.css',
overrides: '/app/branding-overrides.css',
Expand Down
Loading