feat: Add name fields to Board/SoC monitoring information via YAML config#476
Draft
Copilot wants to merge 2 commits into
Draft
feat: Add name fields to Board/SoC monitoring information via YAML config#476Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
8 tasks
- Add `name` field to `SocInfo` and `BoardInfo` structs in data_structures.rs - Add `name` field to `SocInfo` and `BoardInfo` in settingsservice monitoring_types.rs - Create name_config.rs module with MonitoringNamesConfig for loading YAML config - Update DataStore to load name config via with_name_config() constructor - Update MonitoringServerManager::new() to load names from /etc/piccolo/monitoring_names.yaml - Add print display of name fields in print_soc_info() and print_board_info() - Create examples/resources/monitoring_names.yaml as reference config file - Add serde_yaml and tempfile dependencies to monitoringserver - Update all existing tests to include the new name field - Add new unit tests for name configuration loading and lookup Agent-Logs-Url: https://github.com/eclipse-pullpiri/pullpiri/sessions/8d02f053-98a4-4a99-a0b6-9c3f4291de86 Co-authored-by: Chulhee1Lee <104404644+Chulhee1Lee@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add name fields for Board and SoC in monitoring information
feat: Add name fields to Board/SoC monitoring information via YAML config
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoardInfoandSocInfohad no human-readablenamefield, making it impossible to identify them on dashboards or in monitoring output. Names are assigned via a pre-defined YAML configuration file mapping IP-based IDs to names.Changes
New
namefieldspub name: StringtoSocInfoandBoardInfoin bothmonitoringserver/data_structures.rsandsettingsservice/monitoring_types.rsprint_soc_info()andprint_board_info()now display the nameName configuration module (
name_config.rs)MonitoringNamesConfigloads/etc/piccolo/monitoring_names.yamlat startupDataStore::with_name_config(path)constructor wires config into the store; names are applied when a SoC/Board is first createdConfig file format
Deploy to
/etc/piccolo/monitoring_names.yaml:IDs follow the existing IP-grouping scheme (board: last octet rounded to nearest 100, SoC: nearest 10). An annotated example config is added at
examples/resources/monitoring_names.yaml.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
invalid_address/home/REDACTED/work/pullpiri/pullpiri/src/target/debug/deps/settingsservice-7151bdac2bda69a9 /home/REDACTED/work/pullpiri/pullpiri/src/target/debug/deps/settingsservice-7151bdac2bda69a9 embed-bitcode=no -C 64-REDACTED-linux-gnu/bin/rust-lld --test --check-cfg cfg(docsrs,test) --check-cfg cfg(feature, values()) -C metadata=883035a92c461d60 -C 6a/b�� 6a/build_script_build-8b7fad2b5185066a.2n445sz9rwp7j2xm4wyzcruio.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.2zxopgxajrmoklf5x6glgr245.1dgduxs.rcgu.o lib/rustlib/x86_64-REDACTED-linux-gnu/bin/self-contained/cc ror_impl-64b650d/bin/bash ror_impl-64b650d--norc ror_impl-64b650d--noprofile ror_impl-64b650dembed-bitcode=no(dns block)/home/REDACTED/work/pullpiri/pullpiri/src/target/debug/deps/settingsservice-8258990b1d9ca047 /home/REDACTED/work/pullpiri/pullpiri/src/target/debug/deps/settingsservice-8258990b1d9ca047 6a/build_script_build-8b7fad2b5185066a.08ceeak5bxp4cypcmeyg0mhri.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.0p68ctsmcddgmefbha857pn91.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.0uktp5n5yz6pqjcpcl6lnhq3d.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.1e5aybputlegs0853jxfs7u08.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.1wc3hvz9ihd3mh3gf928vy4pp.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.257c01ftwkefiyplff3fyuttm.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.29v51bfrb03zvyfmufb54s5p0.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.2ac5gp9vruh81l3t8iup7lrlj.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.2ac8e1hc9ovfbexut9pa2a5e5.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.2jnu57u576squlmigke59lkzs.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.2k6jbxboyum0ktipevh8gkgm5.1dgduxs.rcgu.o 6a/b�� 6a/build_script_build-8b7fad2b5185066a.2n445sz9rwp7j2xm4wyzcruio.1dgduxs.rcgu.o 6a/build_script_build-8b7fad2b5185066a.2zxopgxajrmoklf5x6glgr245.1dgduxs.rcgu.o ror_impl-64b650d/home/REDACTED/work/pullpiri/pullpiri/src/target/debug/deps/time_macros-0a14e79f90/home/REDACTED/work/pullpiri/pullpiri/src/target/debug/deps/rustcpAdc7M/symbols.o ror_impl-64b650dgrep ror_impl-64b650d^error ror_impl-64b650d/home/REDACTED/work/pullpiri/pullpiri/src/target/debug/deps/time_macros-0a14e79f90/home/REDACTED/work/pullpiri/pullpiri/src/target/debug/deps/settingsservice-45707313ceb7e5b3.03npfbfk94acordovx7xrvyse.0gebwgf.rcgu.o ror_impl-64b650d/home/REDACTED/work/pullpiri/pullpiri/src/target/debug/deps/time_macros-0a14e79f90/home/REDACTED/work/pullpiri/pullpiri/src/target/debug/deps/settingsservice-45707313ceb7e5b3.0573mmi1drfiwv4hed79mx82o.0gebwgf.rcgu.o(dns block)If you need me to access, download, or install something from one of these locations, you can either: