feat: add shared SCORE coding instructions#55
Open
FScholPer wants to merge 1 commit into
Open
Conversation
a-zw
reviewed
May 26, 2026
|
|
||
| ALWAYS create new objects, NEVER mutate existing ones: | ||
| - Return new instances rather than modifying in place | ||
| - Use spread operators, `List.copyOf()`, `Map.copyOf()`, or equivalent |
a-zw
reviewed
May 26, 2026
| ## Pre-Commit Checklist | ||
| - [ ] All tests pass locally | ||
| - [ ] No lint errors or warnings | ||
| - [ ] No `console.log` / `System.out.println` left in production code |
a-zw
suggested changes
May 26, 2026
a-zw
left a comment
a-zw
left a comment
There was a problem hiding this comment.
Seems to be just AI-slop instead of sensible coding instructions aligned to S-CORE needs.
| - Avoid deep nesting; break logic into helpers | ||
|
|
||
| ## Dependencies & Configuration | ||
| - Pin all dependency versions in `requirements.txt` or `pyproject.toml` |
There was a problem hiding this comment.
We use Bazel here, so we do it differently.
| ## Mandatory Checks Before Every Commit | ||
| - [ ] No hardcoded secrets (API keys, passwords, tokens) | ||
| - [ ] All user inputs validated at system boundaries | ||
| - [ ] SQL injection prevention (parameterized queries only) |
There was a problem hiding this comment.
Are actually using any SQL anywhere in S-CORE?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This PR adds the shared SCORE instruction pack under
.github/instructions/.Why
Extracted from oversized PR #51 to keep review focused and faster.
Out of scope
Validation
Merge Order
Relationship to original PR
This PR is part of the split of oversized PR #51.