fix: correct include path and BUILD dep for config_daemon#9
Open
Chahult wants to merge 4 commits into
Open
Conversation
Contributor
Chahult
commented
May 20, 2026
Chahult
commented
- Replace internal path 'platform/aas/mw/lifecycle/application.h' with OSS path 'src/lifecycle_client_lib/include/application.h' in config_daemon.h
- Add missing @score_lifecycle_health//src/lifecycle_client_lib:application dep to the 'interface' cc_library in BUILD so the header compiles
…score#4) * feat: add build acceptlist CI check for CfgD & CfgP targets * fix: apply buildifier formatting and fix copyright headers --------- Co-authored-by: chahul.turkar <chahul.turkar@bti.bmwgroup.com>
* feat: set CI configuration for config_management - Add 4 CI workflows: tests.yml, static-analysis.yml, bzlmod-lock-check.yml, score-pr-checks.yml - Update .bazelrc: score_communication tracing stub flag, score_variant=True, host_gcc config using @gcc_toolchain - Align MODULE.bazel deps with OSS mirror (rules_python 1.8.3, platforms 1.0.0, rules_rust 0.68.1-score, rules_cc 0.2.16, aspect_rules_lint 2.0.0, score_logging 0.1.0) - Pin score_baselibs to commit 052c2f271be4 (avoids non-dev toolchains_llvm conflict), add rules_boost archive_override - Add score_docs_as_code, score_crates single_version_overrides - Add score_lifecycle_health dep - Remove MODULE.bazel.lock from .gitignore, commit fresh lockfile - Fix copyright header in tests/rust/test_main.rs * chore: configure CODEOWNERS with project maintainers * chore: address review comments - CODEOWNERS: apply suggested maintainers list - workflows: replace ubuntu-latest with ubuntu-24.04 in all jobs --------- Co-authored-by: chahul.turkar <chahul.turkar@bti.bmwgroup.com>
- Replace internal path 'platform/aas/mw/lifecycle/application.h' with OSS path 'src/lifecycle_client_lib/include/application.h' in config_daemon.h - Add missing @score_lifecycle_health//src/lifecycle_client_lib:application dep to the 'interface' cc_library in BUILD so the header compiles
Chahult
requested review from
LittleHuba,
antonkri,
castler,
michaelsaborov and
ramceb
as code owners
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
…zelrc - Replace bazel_dep(score_tooling, version=1.1.2) with a git_override matching what score_communication@main requires. score_communication@main uses a non-registry git_override for score_tooling, so the root module must also provide an override; without it Bazel fails with 'bad bazel_dep on module score_tooling with no version'. - Remove stale .bazelrc flag @score_communication//score/mw/com/flags:tracing_library=stub; that Bazel package no longer exists in score_communication@main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.