Fix most of line length errors plus some other errors

[Aymen-Soussi-01]

First PR to address linting errors

This PR resolves 91 linting errors across the codebase.

The changes include:

• Removing unnecessary variable assignments
• Returning directly instead of using a final else block
• Returning directly instead of assigning variables before returning
• Removing unused imports
• Sorting import blocks
• Removing unused variables
• Removing unnecessary f prefixes from strings when not required (e.g., f"hello" → "hello")

Note: Docs build and tests are running with no issues after the changes.

Related to: #205

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: ccce323d-9ab4-40cf-bca6-60ca4eb1f672
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (73 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (122 packages loaded, 862 targets configured)

Analyzing: target //src:license-check (129 packages loaded, 2423 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2472 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4488 targets configured).
[10 / 13] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 14.134s, Critical Path: 0.40s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
[main] INFO Querying Eclipse Foundation for license data for 84 items.
[main] INFO Found 58 items.
[main] INFO Querying ClearlyDefined for license data for 26 items.
[main] ERROR Error response from ClearlyDefined 429

[github-actions]

The created documentation from the pull request is available at: docu-html

[MaximilianSoerenPollak]

This is an implicity concatination.
This should not be working / allowed.

Always make sure if you split a string accross multiple lines to excplitily concatinate it via a '+' or a multiline string

[AlexanderLanin]

Maybe we should discuss that + rule. It does seem rather unnatural

[Aymen-Soussi-01]

Fixed. Please resolve.

[MaximilianSoerenPollak]

@AlexanderLanin I think we should have a formatter enforce / reformat the lines too long (except comments and multiline strings) no? Seems much easier and then also consistent

[Aymen-Soussi-01]

@AlexanderLanin I think we should have a formatter enforce / reformat the lines too long (except comments and multiline strings) no? Seems much easier and then also consistent

That's a good suggestion but we need to handle many cases like comments formatting