Skip to content

Fix for CPP literal include #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximilianSoerenPollak merged 3 commits into from
Apr 17, 2026
Merged

Fix for CPP literal include #493

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6ebd96
Fix for CPP literal include
tizava Apr 16, 2026
f0e940c
Modify the right function
tizava Apr 16, 2026
bec77ef
Fix review findings
tizava Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ def _rewrite_needs_json_to_sourcelinks(labels):
s = str(x)
if s.endswith("//:needs_json"):
out.append(s.replace("//:needs_json", "//:sourcelinks_json"))
else:
out.append(s)
#Items which do not end up with '//:needs_json' shall not be appended to 'out'.
#They are treated separately and are not related to source code linking.
return out

def _merge_sourcelinks(name, sourcelinks, known_good = None):
Expand Down
Loading