Skip to content

Msp disallow needextends on options#544

Draft
MaximilianSoerenPollak wants to merge 3 commits into
eclipse-score:mainfrom
MaximilianSoerenPollak:MSP_disallow_needextends_on_options
Draft

Msp disallow needextends on options#544
MaximilianSoerenPollak wants to merge 3 commits into
eclipse-score:mainfrom
MaximilianSoerenPollak:MSP_disallow_needextends_on_options

Conversation

@MaximilianSoerenPollak
Copy link
Copy Markdown
Contributor

📌 Description

⚠️ do not merge.

This is a PoC until it is agreed upon if this is needed and what to check for.
This is just to show that it is possible, and how it would look like.

Missing:

  • Documentation
  • Tests

Fixes: #345

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions
Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 4e8c3309-7f22-4c95-b28a-d8b4fdc85a52
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 4.626s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

- thing
- absolutely

unmutable_options:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word is "immutable".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

Docs as code allow to implies changes which causes side effects in other modules/features/components

2 participants