Skip to content

feat!: Remove socom::Runtime::subscribe find service()#98

Draft
lurtz wants to merge 7 commits into
eclipse-score:mainfrom
elektrobit-contrib:remove-socom-subscribe_find_service
Draft

feat!: Remove socom::Runtime::subscribe find service()#98
lurtz wants to merge 7 commits into
eclipse-score:mainfrom
elektrobit-contrib:remove-socom-subscribe_find_service

Conversation

@lurtz
Copy link
Copy Markdown
Contributor

@lurtz lurtz commented Apr 21, 2026

Runtime::subscribe_find_service() carries a lot of complexity caused by

  • concurrent Server creation / destruction
  • concurrent calls
  • fan out to subscribers
  • fan out to bridges
  • a guarantee that no callback will be called after Find_subscription_handle destructor completion

If we do not need Runtime::subscribe_find_service() we can simplify the code a lot. However we have to find other solutions to some use cases previously covered by Runtime::subscribe_find_service()

  • TODO list of use cases here

@lurtz lurtz changed the title Remove socom::Runtime::subscribe find service() feat!: Remove socom::Runtime::subscribe find service() Apr 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 298c42dc-abf7-44d5-99ec-d0d497ca89de
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)

Analyzing: target //:license-check (80 packages loaded, 10 targets configured)

Analyzing: target //:license-check (147 packages loaded, 2366 targets configured)

Analyzing: target //:license-check (160 packages loaded, 5367 targets configured)

Analyzing: target //:license-check (171 packages loaded, 9701 targets configured)

INFO: Analyzed target //:license-check (174 packages loaded, 11717 targets configured).
[7 / 13] [Prepa] Creating source manifest for @@score_tooling+//dash/tool/formatters:dash_format_converter [for tool]
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 27.113s, Critical Path: 0.39s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Comment on lines 38 to 39
std::atomic<bool> m_request_find_service_created{false};
std::atomic<bool> m_request_find_service_destroyed{true};
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two still needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, their name is confusing.

Bridges still have a callback for getting a notification when a Client_connector has been created or destroyed. If we figure out that we do not need that as well, the Runtime could be simplified tremendously.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is also related to #86 (comment)

We should discuss and document what each daemons knows a priori via configuration and what is considered to be dynamic.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants