feat!: Remove socom::Runtime::subscribe find service()#98
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
| std::atomic<bool> m_request_find_service_created{false}; | ||
| std::atomic<bool> m_request_find_service_destroyed{true}; |
There was a problem hiding this comment.
yes, their name is confusing.
Bridges still have a callback for getting a notification when a Client_connector has been created or destroyed. If we figure out that we do not need that as well, the Runtime could be simplified tremendously.
There was a problem hiding this comment.
I guess this is also related to #86 (comment)
We should discuss and document what each daemons knows a priori via configuration and what is considered to be dynamic.
There was a problem hiding this comment.
See also this discussion about dynamic behavior: https://github.com/orgs/eclipse-score/discussions/1984#discussioncomment-16699653
Runtime::subscribe_find_service()carries a lot of complexity caused byIf we do not need
Runtime::subscribe_find_service()we can simplify the code a lot. However we have to find other solutions to some use cases previously covered byRuntime::subscribe_find_service()